You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/06/10 16:19:00 UTC
[jira] [Commented] (IMPALA-8603) Some custom cluster tests print
error messages after IMPALA-1653 was fixed
[ https://issues.apache.org/jira/browse/IMPALA-8603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860122#comment-16860122 ]
ASF subversion and git services commented on IMPALA-8603:
---------------------------------------------------------
Commit f6d40b37c8b13131cbc75db6a7327c34bf0c5a34 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f6d40b3 ]
IMPALA-8603: remove confusing logging from custom cluster tests
IMPALA-1653 added explicit closing of the HS2 session that is created
by ImpalaTestSuite during teardown. For the custom cluster tests, this
sometimes fails, either because the impalad was shutdown and is no
longer reachable or because it was restarted and the new impalad
doesn't know about the session that was created before restart.
Currently, when these errors occur we log them. However, this is
confusing because several custom cluster tests now log errors even
though they succeed. This patch changes this to simply ignore the
errors.
One concern is that a test may hit a genuine error here and if so we
won't have the logging for it. If this happens, though, it should
generally be possible for a dev to repro the error with the logging
enabled.
Change-Id: I96144fdbe6cc9bf0f01a9951420ee6f281fa6649
Reviewed-on: http://gerrit.cloudera.org:8080/13502
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Some custom cluster tests print error messages after IMPALA-1653 was fixed
> --------------------------------------------------------------------------
>
> Key: IMPALA-8603
> URL: https://issues.apache.org/jira/browse/IMPALA-8603
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 3.3.0
> Reporter: Lars Volker
> Assignee: Thomas Tauber-Marshall
> Priority: Major
> Labels: hs2, regression
>
> The fix for IMPALA-1653 seems to introduce error messages at the end of some custom cluster tests. It looks like tests are affected that leave the cluster down.
> {noformat}
> PASSED-- closing connection to: localhost:21000 [4/768]
> -- closing connection to: localhost:21050
> -- 2019-05-30 13:02:56,968 ERROR MainThread: Failed to open transport (tries_left=3)
> Traceback (most recent call last):
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 961, in _execute
> return func(request)
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/_thrift_gen/TCLIService/TCLIService.py", line 207, in CloseSession
> return self.recv_CloseSession()
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/_thrift_gen/TCLIService/TCLIService.py", line 219, in recv_CloseSession
> (fname, mtype, rseqid) = iprot.readMessageBegin()
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/protocol/TBinaryProtocol.py", line 126, in readMessageBegin
> sz = self.readI32()
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/protocol/TBinaryProtocol.py", line 206, in readI32
> buff = self.trans.readAll(4)
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TTransport.py", line 58, in readAll
> chunk = self.read(sz - have)
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TTransport.py", line 159, in read
> self.__rbuf = StringIO(self.__trans.read(max(sz, self.__rbuf_size)))
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TSocket.py", line 120, in read
> message='TSocket read 0 bytes')
> TTransportException: TSocket read 0 bytes
> -- 2019-05-30 13:02:56,969 ERROR MainThread: Failed to open transport (tries_left=2)
> Traceback (most recent call last):
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 958, in _execute
> open_transport(transport)
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 990, in open_transport
> transport.open()
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TTransport.py", line 149, in open
> return self.__trans.open()
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TSocket.py", line 101, in open
> message=message)
> TTransportException: Could not connect to localhost:21050
> -- 2019-05-30 13:02:56,970 ERROR MainThread: Failed to open transport (tries_left=1)
> Traceback (most recent call last):
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 958, in _execute
> open_transport(transport)
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 990, in open_transport
> transport.open()
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TTransport.py", line 149, in open
> return self.__trans.open()
> File "/opt/Impala-Toolchain/thrift-0.9.3-p5/python/lib/python2.7/site-packages/thrift/transport/TSocket.py", line 101, in open
> message=message)
> TTransportException: Could not connect to localhost:21050
> Failed after retrying 3 times
> Traceback (most recent call last):
> File "/home/lv/i7/tests/common/impala_connection.py", line 283, in close
> self.__cursor.close()
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 248, in close
> self.session.close()
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 1041, in close
> self._rpc('CloseSession', req)
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 944, in _rpc
> response = self._execute(func_name, request)
> File "/home/lv/i7/infra/python/env/local/lib/python2.7/site-packages/impala/hiveserver2.py", line 975, in _execute
> .format(self.retries))
> HiveServer2Error: Failed after retrying 3 times
> {noformat}
> The tests still return 0 (success) but I found this confusing.
> [~twmarshall] - I'm not sure what the best workaround here is. Should we ignore "Could not connect to" in {{impala_connection.py}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org