You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/16 09:56:17 UTC

[GitHub] [shardingsphere] taojintianxia opened a new pull request, #23581: Fix : fix some incorrect spelling matrics

taojintianxia opened a new pull request, #23581:
URL: https://github.com/apache/shardingsphere/pull/23581

   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #23581: Fix : fix some incorrect spelling matrics

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #23581:
URL: https://github.com/apache/shardingsphere/pull/23581#discussion_r1071091668


##########
test/e2e/agent/plugins/metrics/src/test/java/org/apache/shardingsphere/test/e2e/agent/metrics/MetricsPluginE2EIT.java:
##########
@@ -38,29 +38,29 @@
 @Slf4j
 public final class MetricsPluginE2EIT extends BasePluginE2EIT {
     
-    public static final String ROUTED_INSERT_SQL = "routed_insert_sql_total";
+    public static final String ROUTED_INSERT_SQL = "route_sql_insert_total";
     
-    public static final String ROUTED_UPDATE_SQL = "routed_update_sql_total";
+    public static final String ROUTED_UPDATE_SQL = "route_sql_update_total";
     
-    public static final String ROUTED_DELETE_SQL = "routed_delete_sql_total";
+    public static final String ROUTED_DELETE_SQL = "route_sql_delete_total";
     
-    public static final String ROUTED_SELECT_SQL = "routed_select_sql_total";
+    public static final String ROUTED_SELECT_SQL = "route_sql_select_total";

Review Comment:
   I see, thanks for pointing it out 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #23581: Fix : fix some incorrect spelling matrics

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #23581:
URL: https://github.com/apache/shardingsphere/pull/23581#discussion_r1071069658


##########
test/e2e/agent/plugins/metrics/src/test/java/org/apache/shardingsphere/test/e2e/agent/metrics/MetricsPluginE2EIT.java:
##########
@@ -38,29 +38,29 @@
 @Slf4j
 public final class MetricsPluginE2EIT extends BasePluginE2EIT {
     
-    public static final String ROUTED_INSERT_SQL = "routed_insert_sql_total";
+    public static final String ROUTED_INSERT_SQL = "route_sql_insert_total";
     
-    public static final String ROUTED_UPDATE_SQL = "routed_update_sql_total";
+    public static final String ROUTED_UPDATE_SQL = "route_sql_update_total";
     
-    public static final String ROUTED_DELETE_SQL = "routed_delete_sql_total";
+    public static final String ROUTED_DELETE_SQL = "route_sql_delete_total";
     
-    public static final String ROUTED_SELECT_SQL = "routed_select_sql_total";
+    public static final String ROUTED_SELECT_SQL = "route_sql_select_total";

Review Comment:
   These changes were made recently. https://github.com/apache/shardingsphere/pull/23553/files#diff-5a3c440d324b8e735f8bdcdda07cebdb54711c6d3130d47024646b4a753b57dc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia closed pull request #23581: Fix : fix some incorrect spelling matrics

Posted by GitBox <gi...@apache.org>.
taojintianxia closed pull request #23581: Fix : fix some incorrect spelling matrics
URL: https://github.com/apache/shardingsphere/pull/23581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org