You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "liujiayi771 (via GitHub)" <gi...@apache.org> on 2024/03/27 08:19:42 UTC

[PR] [VL] Support kurtosis aggregate function [incubator-gluten]

liujiayi771 opened a new pull request, #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151

   ## What changes were proposed in this pull request?
   
   Support kurtosis agg function.
   
   ## How was this patch tested?
   
   `VeloxAggregateFunctionsSuite.kurtosis`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2027024196

   ===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
   <table border="1" cellpadding="0" cellspacing="0">
                   <tbody>
                       <tr>
                               <td><font color=#000000>query</font></td>
                               <td><font color=#000000>log/native_5151_time.csv</font></td>
                               <td><font color=#000000>log/native_master_03_28_2024_471423d7f_time.csv</font></td>
                               <td><font color=#000000>difference</font></td>
                               <td><font color=#000000>percentage</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q1</font></td>
                               <td><font color=#6F9915>35.91</font></td>
                               <td><font color=#6F9915>34.16</font></td>
                               <td><font color=#6F9915>-1.747</font></td>
                               <td><font color=#6F9915>95.14%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q2</font></td>
                               <td><font color=#6F9915>24.40</font></td>
                               <td><font color=#6F9915>23.32</font></td>
                               <td><font color=#6F9915>-1.080</font></td>
                               <td><font color=#6F9915>95.57%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q3</font></td>
                               <td><font color=#6F9915>37.31</font></td>
                               <td><font color=#6F9915>36.66</font></td>
                               <td><font color=#6F9915>-0.655</font></td>
                               <td><font color=#6F9915>98.25%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q4</font></td>
                               <td><font color=#6F9915>38.77</font></td>
                               <td><font color=#6F9915>37.96</font></td>
                               <td><font color=#6F9915>-0.811</font></td>
                               <td><font color=#6F9915>97.91%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q5</font></td>
                               <td><font color=#F92663>69.09</font></td>
                               <td><font color=#F92663>70.39</font></td>
                               <td><font color=#F92663>1.294</font></td>
                               <td><font color=#F92663>101.87%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q6</font></td>
                               <td><font color=#6F9915>7.13</font></td>
                               <td><font color=#6F9915>7.04</font></td>
                               <td><font color=#6F9915>-0.092</font></td>
                               <td><font color=#6F9915>98.71%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q7</font></td>
                               <td><font color=#6F9915>83.60</font></td>
                               <td><font color=#6F9915>82.67</font></td>
                               <td><font color=#6F9915>-0.938</font></td>
                               <td><font color=#6F9915>98.88%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q8</font></td>
                               <td><font color=#F92663>85.37</font></td>
                               <td><font color=#F92663>86.75</font></td>
                               <td><font color=#F92663>1.375</font></td>
                               <td><font color=#F92663>101.61%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q9</font></td>
                               <td><font color=#6F9915>123.81</font></td>
                               <td><font color=#6F9915>123.05</font></td>
                               <td><font color=#6F9915>-0.756</font></td>
                               <td><font color=#6F9915>99.39%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q10</font></td>
                               <td><font color=#6F9915>43.28</font></td>
                               <td><font color=#6F9915>43.02</font></td>
                               <td><font color=#6F9915>-0.256</font></td>
                               <td><font color=#6F9915>99.41%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q11</font></td>
                               <td><font color=#F92663>19.76</font></td>
                               <td><font color=#F92663>20.33</font></td>
                               <td><font color=#F92663>0.570</font></td>
                               <td><font color=#F92663>102.89%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q12</font></td>
                               <td><font color=#F92663>23.83</font></td>
                               <td><font color=#F92663>25.42</font></td>
                               <td><font color=#F92663>1.587</font></td>
                               <td><font color=#F92663>106.66%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q13</font></td>
                               <td><font color=#6F9915>48.12</font></td>
                               <td><font color=#6F9915>46.86</font></td>
                               <td><font color=#6F9915>-1.261</font></td>
                               <td><font color=#6F9915>97.38%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q14</font></td>
                               <td><font color=#6F9915>20.61</font></td>
                               <td><font color=#6F9915>17.47</font></td>
                               <td><font color=#6F9915>-3.144</font></td>
                               <td><font color=#6F9915>84.75%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q15</font></td>
                               <td><font color=#6F9915>31.13</font></td>
                               <td><font color=#6F9915>30.68</font></td>
                               <td><font color=#6F9915>-0.452</font></td>
                               <td><font color=#6F9915>98.55%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q16</font></td>
                               <td><font color=#F92663>14.11</font></td>
                               <td><font color=#F92663>16.08</font></td>
                               <td><font color=#F92663>1.972</font></td>
                               <td><font color=#F92663>113.97%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q17</font></td>
                               <td><font color=#F92663>98.99</font></td>
                               <td><font color=#F92663>101.30</font></td>
                               <td><font color=#F92663>2.314</font></td>
                               <td><font color=#F92663>102.34%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q18</font></td>
                               <td><font color=#6F9915>143.59</font></td>
                               <td><font color=#6F9915>142.16</font></td>
                               <td><font color=#6F9915>-1.432</font></td>
                               <td><font color=#6F9915>99.00%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q19</font></td>
                               <td><font color=#6F9915>13.74</font></td>
                               <td><font color=#6F9915>13.68</font></td>
                               <td><font color=#6F9915>-0.058</font></td>
                               <td><font color=#6F9915>99.57%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q20</font></td>
                               <td><font color=#6F9915>30.90</font></td>
                               <td><font color=#6F9915>27.00</font></td>
                               <td><font color=#6F9915>-3.905</font></td>
                               <td><font color=#6F9915>87.36%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q21</font></td>
                               <td><font color=#F92663>228.24</font></td>
                               <td><font color=#F92663>233.01</font></td>
                               <td><font color=#F92663>4.769</font></td>
                               <td><font color=#F92663>102.09%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q22</font></td>
                               <td><font color=#6F9915>15.33</font></td>
                               <td><font color=#6F9915>13.84</font></td>
                               <td><font color=#6F9915>-1.491</font></td>
                               <td><font color=#6F9915>90.27%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>total</font></td>
                               <td><font color=#6F9915>1237.03</font></td>
                               <td><font color=#6F9915>1232.83</font></td>
                               <td><font color=#6F9915>-4.197</font></td>
                               <td><font color=#6F9915>99.66%</font></td>
                       </tr>
                   </tbody>
               </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2022846115

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2026757543

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2022185111

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICEGJ-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** in the following format?
   
       [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2024470634

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2027830118

   ===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
   <table border="1" cellpadding="0" cellspacing="0">
                   <tbody>
                       <tr>
                               <td><font color=#000000>query</font></td>
                               <td><font color=#000000>log/native_master_03_29_2024_time.csv</font></td>
                               <td><font color=#000000>log/native_master_03_28_2024_471423d7f_time.csv</font></td>
                               <td><font color=#000000>difference</font></td>
                               <td><font color=#000000>percentage</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q1</font></td>
                               <td><font color=#6F9915>37.97</font></td>
                               <td><font color=#6F9915>34.16</font></td>
                               <td><font color=#6F9915>-3.809</font></td>
                               <td><font color=#6F9915>89.97%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q2</font></td>
                               <td><font color=#6F9915>23.84</font></td>
                               <td><font color=#6F9915>23.32</font></td>
                               <td><font color=#6F9915>-0.523</font></td>
                               <td><font color=#6F9915>97.81%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q3</font></td>
                               <td><font color=#6F9915>37.86</font></td>
                               <td><font color=#6F9915>36.66</font></td>
                               <td><font color=#6F9915>-1.202</font></td>
                               <td><font color=#6F9915>96.83%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q4</font></td>
                               <td><font color=#6F9915>39.36</font></td>
                               <td><font color=#6F9915>37.96</font></td>
                               <td><font color=#6F9915>-1.394</font></td>
                               <td><font color=#6F9915>96.46%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q5</font></td>
                               <td><font color=#F92663>69.59</font></td>
                               <td><font color=#F92663>70.39</font></td>
                               <td><font color=#F92663>0.796</font></td>
                               <td><font color=#F92663>101.14%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q6</font></td>
                               <td><font color=#6F9915>7.34</font></td>
                               <td><font color=#6F9915>7.04</font></td>
                               <td><font color=#6F9915>-0.301</font></td>
                               <td><font color=#6F9915>95.89%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q7</font></td>
                               <td><font color=#6F9915>83.01</font></td>
                               <td><font color=#6F9915>82.67</font></td>
                               <td><font color=#6F9915>-0.346</font></td>
                               <td><font color=#6F9915>99.58%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q8</font></td>
                               <td><font color=#F92663>86.59</font></td>
                               <td><font color=#F92663>86.75</font></td>
                               <td><font color=#F92663>0.151</font></td>
                               <td><font color=#F92663>100.17%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q9</font></td>
                               <td><font color=#F92663>122.44</font></td>
                               <td><font color=#F92663>123.05</font></td>
                               <td><font color=#F92663>0.605</font></td>
                               <td><font color=#F92663>100.49%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q10</font></td>
                               <td><font color=#6F9915>46.69</font></td>
                               <td><font color=#6F9915>43.02</font></td>
                               <td><font color=#6F9915>-3.666</font></td>
                               <td><font color=#6F9915>92.15%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q11</font></td>
                               <td><font color=#6F9915>20.70</font></td>
                               <td><font color=#6F9915>20.33</font></td>
                               <td><font color=#6F9915>-0.367</font></td>
                               <td><font color=#6F9915>98.23%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q12</font></td>
                               <td><font color=#6F9915>27.11</font></td>
                               <td><font color=#6F9915>25.42</font></td>
                               <td><font color=#6F9915>-1.694</font></td>
                               <td><font color=#6F9915>93.75%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q13</font></td>
                               <td><font color=#6F9915>47.43</font></td>
                               <td><font color=#6F9915>46.86</font></td>
                               <td><font color=#6F9915>-0.574</font></td>
                               <td><font color=#6F9915>98.79%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q14</font></td>
                               <td><font color=#6F9915>20.04</font></td>
                               <td><font color=#6F9915>17.47</font></td>
                               <td><font color=#6F9915>-2.579</font></td>
                               <td><font color=#6F9915>87.13%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q15</font></td>
                               <td><font color=#6F9915>30.81</font></td>
                               <td><font color=#6F9915>30.68</font></td>
                               <td><font color=#6F9915>-0.129</font></td>
                               <td><font color=#6F9915>99.58%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q16</font></td>
                               <td><font color=#F92663>14.26</font></td>
                               <td><font color=#F92663>16.08</font></td>
                               <td><font color=#F92663>1.820</font></td>
                               <td><font color=#F92663>112.76%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q17</font></td>
                               <td><font color=#F92663>101.05</font></td>
                               <td><font color=#F92663>101.30</font></td>
                               <td><font color=#F92663>0.256</font></td>
                               <td><font color=#F92663>100.25%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q18</font></td>
                               <td><font color=#F92663>141.33</font></td>
                               <td><font color=#F92663>142.16</font></td>
                               <td><font color=#F92663>0.836</font></td>
                               <td><font color=#F92663>100.59%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q19</font></td>
                               <td><font color=#6F9915>15.32</font></td>
                               <td><font color=#6F9915>13.68</font></td>
                               <td><font color=#6F9915>-1.632</font></td>
                               <td><font color=#6F9915>89.35%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q20</font></td>
                               <td><font color=#6F9915>27.29</font></td>
                               <td><font color=#6F9915>27.00</font></td>
                               <td><font color=#6F9915>-0.290</font></td>
                               <td><font color=#6F9915>98.94%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#F92663>q21</font></td>
                               <td><font color=#F92663>230.77</font></td>
                               <td><font color=#F92663>233.01</font></td>
                               <td><font color=#F92663>2.235</font></td>
                               <td><font color=#F92663>100.97%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>q22</font></td>
                               <td><font color=#6F9915>13.96</font></td>
                               <td><font color=#6F9915>13.84</font></td>
                               <td><font color=#6F9915>-0.124</font></td>
                               <td><font color=#6F9915>99.11%</font></td>
                       </tr>
                       <tr>
                               <td><font color=#6F9915>total</font></td>
                               <td><font color=#6F9915>1244.76</font></td>
                               <td><font color=#6F9915>1232.83</font></td>
                               <td><font color=#6F9915>-11.932</font></td>
                               <td><font color=#6F9915>99.04%</font></td>
                       </tr>
                   </tbody>
               </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "rui-mo (via GitHub)" <gi...@apache.org>.
rui-mo commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2024266506

   @liujiayi771 Thanks for the suggestion. It looks nice to add these checks back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2024242881

   @rui-mo Could you help review? There is an accuracy issue similar to covariance. I remember we directly removed the corresponding query for covariance in sql file before. Do you think it would be better to directly modify the result?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2026903490

   cc @rui-mo @PHILO-HE. Could you help review again. I have rebased the latest main branch, and all CI tests passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2024324408

   > @liujiayi771 Thanks for the suggestion. It looks nice to add these checks back.
   
   Ok. I will do this in another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2022187713

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2022766992

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2022185427

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2022191309

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Support kurtosis aggregate function [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5151:
URL: https://github.com/apache/incubator-gluten/pull/5151#issuecomment-2026761463

   Run Gluten Clickhouse CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org