You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/06 20:50:41 UTC

[GitHub] [airflow] Taragolis commented on pull request #25494: Deprecate usage of `extra[host]` in AWS's connection

Taragolis commented on PR #25494:
URL: https://github.com/apache/airflow/pull/25494#issuecomment-1207280912

   @gmcrocetti 
   
   Since https://github.com/apache/airflow/pull/25416 merged would be nice also update placeholder for UI:
   https://github.com/apache/airflow/blob/6657684ae0b558906e0da0693e6644511a419e0d/airflow/providers/amazon/aws/hooks/base_aws.py#L626-L628
   
   > but after discussions it occurred me host is not semantically correct for the proposed use case.
   
   I just thought that we could inform users if they somehow use `Connection.host` (might be defined in current version of provider) that this option won't work. Same as we inform that if they use `profile` which related to deprecated value, and do not related to actual `profile_name` but it just an idea.
   
   https://github.com/apache/airflow/blob/2e2e86d9e43989ed039afc07fa8efe29bf5d170c/airflow/providers/amazon/aws/utils/connection_wrapper.py#L138-L147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org