You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/01/08 11:28:52 UTC

[GitHub] flink issue #3078: [FLINK-5355] Handle AmazonKinesisException gracefully in ...

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3078
  
    Thank you for opening a pull request for this @skidder !
    
    I think `AmazonServiceException` will also be thrown for client errors (ex., wrong parameters for API calls). Whether an exception is caused by client or server is indicated by `AmazonServiceException#getErrorType()` which returns either `ErrorType.Client`, `ErrorType.Server`, or `ErrorType.Unknown`
    
    So, instead of simply catching a `AmazonServiceException`, I wonder if we should only perform exponential backoff for service exception with `Server` and `Unknown` error types. We need to also see what type `ProvisionedThroughputExceededException` is, and see if it is included as a `Server` or `Unknown`; if not, handle that also.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---