You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/22 02:36:09 UTC
[GitHub] [airflow] uranusjr commented on a change in pull request #19722: Databricks - allow Azure SP authentication on other Azure clouds
uranusjr commented on a change in pull request #19722:
URL: https://github.com/apache/airflow/pull/19722#discussion_r753910269
##########
File path: docs/apache-airflow-providers-databricks/connections/databricks.rst
##########
@@ -72,6 +72,7 @@ Extra (optional)
* ``azure_tenant_id``: ID of the Azure Active Directory tenant
* ``azure_resource_id``: optional Resource ID of the Azure Databricks workspace (required if Service Principal isn't
a user inside workspace)
+ * ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. Should be specified as hostname with protocol. For example: ``https://login.microsoftonline.de``.
Review comment:
```suggestion
* ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. The endpoint must contain a protocol. For example: ``https://login.microsoftonline.de``.
```
Hostname and protocol are distincts part of a URL, and it is technically not correct to say “hostname with protocol”.
##########
File path: docs/apache-airflow-providers-databricks/connections/databricks.rst
##########
@@ -72,6 +72,7 @@ Extra (optional)
* ``azure_tenant_id``: ID of the Azure Active Directory tenant
* ``azure_resource_id``: optional Resource ID of the Azure Databricks workspace (required if Service Principal isn't
a user inside workspace)
+ * ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. Should be specified as hostname with protocol. For example: ``https://login.microsoftonline.de``.
Review comment:
```suggestion
* ``azure_ad_endpoint``: optional host name of Azure AD endpoint if you're using special `Azure Cloud (GovCloud, China, Germany) <https://docs.microsoft.com/en-us/graph/deployments#app-registration-and-token-service-root-endpoints>`_. The value must contain a protocol. For example: ``https://login.microsoftonline.de``.
```
Hostname and protocol are distincts part of a URL, and it is technically not correct to say “hostname with protocol”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org