You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org> on 2016/07/27 16:22:03 UTC

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Dimitris Tsirogiannis has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3790

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................

Add TPC-H based planner tests for Kudu tables

This commit adds a set of planner tests for Kudu tables based on the 22
TPC-H queries.

Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
---
M fe/src/test/java/com/cloudera/impala/planner/KuduPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
2 files changed, 1,268 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/3790/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has uploaded a new patch set (#2).

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................

Add TPC-H based planner tests for Kudu tables

This commit adds a set of planner tests for Kudu tables based on the 22
TPC-H queries.

Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
---
M fe/src/test/java/com/cloudera/impala/planner/KuduPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
2 files changed, 1,268 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/3790/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................


Patch Set 3: Code-Review+2

Rebase, carry Alex's +1

-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3790/1/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
File testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test:

Line 713: # Q13 - tpch_kudu.customer Distribution Query
> bad find+replace
Good catch. Thanks. Done


Line 863:       s_comment like '%tpch_kudu.customer%Complaints%'
> bad find+replace
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3790/1/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
File testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test:

Line 713: # Q13 - tpch_kudu.customer Distribution Query
bad find+replace


Line 863:       s_comment like '%tpch_kudu.customer%Complaints%'
bad find+replace


-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Add TPC-H based planner tests for Kudu tables

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.

Change subject: Add TPC-H based planner tests for Kudu tables
......................................................................


Add TPC-H based planner tests for Kudu tables

This commit adds a set of planner tests for Kudu tables based on the 22
TPC-H queries.

Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Reviewed-on: http://gerrit.cloudera.org:8080/3790
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/test/java/com/cloudera/impala/planner/KuduPlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
2 files changed, 1,268 insertions(+), 0 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Dimitris Tsirogiannis: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c40534b72b9aa1ee582b9679c2a63cad52df703
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins