You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by trkurc <gi...@git.apache.org> on 2016/03/19 19:53:23 UTC
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/291
NIFI-1651 unit tests work on windows. removed contributor name/package from data and schema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi NIFI-1651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit bfd90e6587a449f23dd1ddc6e2cc36448e59e881
Author: trkurc <tk...@gizmolabs.org>
Date: 2016-03-19T18:48:44Z
NIFI-1651 unit tests work on windows. removed contributor name/package from data and schema
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198978900
Windows 7, Maven 3.3.3, and JDK 8u71 looks good here.
Will look for updates from @pvillard31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198968796
Tried a mvn clean install without success on my side (I missed something?):
[mvn_output.txt](https://github.com/apache/nifi/files/181411/mvn_output.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198969736
Pierre, what environment are you running on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198982574
Sorry for the delay... I am on a different computer than usual and forgot to check the git property. Did a full clone again (so slow with airport wifi...) and checked the schema (looks OK to me). The git property solved most of the issues, but some are remaining:
```
Running org.apache.nifi.processors.kite.TestAvroRecordConverter
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.377 sec <<< FAILURE! - in org.apache.nifi.processors.kite.TestAvroRecordConverter
testDefaultConversion(org.apache.nifi.processors.kite.TestAvroRecordConverter) Time elapsed: 0.011 sec <<< ERROR!
org.apache.nifi.processors.kite.AvroRecordConverter$AvroConversionException: Cannot convert 5.5 to double
at org.apache.nifi.processors.kite.AvroRecordConverter.convertData(AvroRecordConverter.java:246)
at org.apache.nifi.processors.kite.AvroRecordConverter.convert(AvroRecordConverter.java:170)
at org.apache.nifi.processors.kite.TestAvroRecordConverter.testDefaultConversion(TestAvroRecordConverter.java:98)
Running org.apache.nifi.processors.kite.TestConfigurationProperty
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.849 sec - in org.apache.nifi.processors.kite.TestConfigurationProperty
Running org.apache.nifi.processors.kite.TestConvertAvroSchema
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.22 sec <<< FAILURE! - in org.apache.nifi.processors.kite.TestConvertAvroSchema
testBasicConversion(org.apache.nifi.processors.kite.TestConvertAvroSchema) Time elapsed: 0.21 sec <<< FAILURE!
java.lang.AssertionError: Should convert 2 rows expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.apache.nifi.processors.kite.TestConvertAvroSchema.testBasicConversion(TestConvertAvroSchema.java:78)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198987604
@trkurc I am currently checking on my side why the other unit tests are in failure. But as you said, this is not related to this PR, so it is OK for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198970178
Windows 7 Pro / Maven 3.3.9 / Java 1.8.0_74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198974775
Using Windows 10, maven 3.3.9, java 1.7.0_79 the nifi-kite-bundle fails on this unit test before this patch. nifi-kite-bundle unit tests work fine after this patch. +1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198995171
hmm good find @pvillard31 We need to make the code more locale tolerant apparently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198971642
Did you clone the code with autocrlf? Does the schema in src/test/resources have line endings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198963197
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198994990
Just for the record, the error is because of my local env. This is fixed by setting the locale to US on the scanner:
`scanner.useLocale(java.util.Locale.US);`
I don't know if there is a way to set this at a global scale.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198986806
@pvillard31 - I was able to replicate the errors in the txt file you included by adding \r's to the file (windows line endings). The other errors are on tests that haven't changed in this PR, but I can dig in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198997621
So, likely needs a processor change to add a default locale and some ability to override it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---