You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by chengxiang li <ch...@intel.com> on 2014/08/14 04:43:40 UTC
Review Request 24689: HIVE-7707 Optimize SparkMapRecordHandler
implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24689/
-----------------------------------------------------------
Review request for hive, Brock Noland and Szehon Ho.
Bugs: HIVE-7707
https://issues.apache.org/jira/browse/HIVE-7707
Repository: hive-git
Description
-------
Current SparkRecordHandler is cloned from ExecMapper, which introduce several unnecessary API restriction and MR specified logic.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 7befaee
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java 8e05011
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 52324c9
Diff: https://reviews.apache.org/r/24689/diff/
Testing
-------
Thanks,
chengxiang li
Re: Review Request 24689: HIVE-7707 Optimize SparkMapRecordHandler
implementation
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24689/#review50553
-----------------------------------------------------------
Ship it!
Looks fine to me.
- Szehon Ho
On Aug. 14, 2014, 2:43 a.m., chengxiang li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24689/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 2:43 a.m.)
>
>
> Review request for hive, Brock Noland and Szehon Ho.
>
>
> Bugs: HIVE-7707
> https://issues.apache.org/jira/browse/HIVE-7707
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Current SparkRecordHandler is cloned from ExecMapper, which introduce several unnecessary API restriction and MR specified logic.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 7befaee
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java 8e05011
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 52324c9
>
> Diff: https://reviews.apache.org/r/24689/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> chengxiang li
>
>
Re: Review Request 24689: HIVE-7707 Optimize SparkMapRecordHandler
implementation
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24689/
-----------------------------------------------------------
(Updated 八月 14, 2014, 2:43 a.m.)
Review request for hive, Brock Noland and Szehon Ho.
Bugs: HIVE-7707
https://issues.apache.org/jira/browse/HIVE-7707
Repository: hive-git
Description
-------
Current SparkRecordHandler is cloned from ExecMapper, which introduce several unnecessary API restriction and MR specified logic.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 7befaee
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java 8e05011
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 52324c9
Diff: https://reviews.apache.org/r/24689/diff/
Testing
-------
Thanks,
chengxiang li