You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/13 23:37:22 UTC
[GitHub] [incubator-druid] clintropolis opened a new pull request #8296:
adjust azure storage retry conditions
clintropolis opened a new pull request #8296: adjust azure storage retry conditions
URL: https://github.com/apache/incubator-druid/pull/8296
### Description
Related to #6573, this PR is a 'shot in the dark' attempt to fix it by making the retry condition checks for the Azure deep storage extension a bit more permissive. The exception reported in the issue is of the form:
```
Caused by: java.io.IOException
at com.microsoft.azure.storage.core.Utility.initIOException(Utility.java:639) ~[?:?]
at com.microsoft.azure.storage.blob.BlobOutputStream.close(BlobOutputStream.java:280) ~[?:?]
at com.microsoft.azure.storage.blob.CloudBlockBlob.upload(CloudBlockBlob.java:580) ~[?:?]
at com.microsoft.azure.storage.blob.CloudBlockBlob.upload(CloudBlockBlob.java:497) ~[?:?]
at io.druid.storage.azure.AzureStorage.uploadBlob(AzureStorage.java:86) ~[?:?]
at io.druid.storage.azure.AzureDataSegmentPusher.uploadDataSegment(AzureDataSegmentPusher.java:115) ~[?:?]
at io.druid.storage.azure.AzureDataSegmentPusher$1.call(AzureDataSegmentPusher.java:155) ~[?:?]
at io.druid.storage.azure.AzureDataSegmentPusher$1.call(AzureDataSegmentPusher.java:151) ~[?:?]
at io.druid.java.util.common.RetryUtils.retry(RetryUtils.java:63) ~[java-util-0.12.3.jar:0.12.3]
at io.druid.java.util.common.RetryUtils.retry(RetryUtils.java:81) ~[java-util-0.12.3.jar:0.12.3]
at io.druid.storage.azure.AzureUtils.retryAzureOperation(AzureUtils.java:58) ~[?:?]
at io.druid.storage.azure.AzureDataSegmentPusher.push(AzureDataSegmentPusher.java:149) ~[?:?]
... 5 more
Caused by: com.microsoft.azure.storage.StorageException: The specified block list is invalid.
at com.microsoft.azure.storage.StorageException.translateException(StorageException.java:89) ~[?:?]
...
```
The Azure retry mechanism considers a `StorageException` for retry, but was not considering `IOException`, which I think is likely incorrect and it should be retry-able.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org