[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #2778: Restore original format of m2:/ URLs modified by aa256463dcefb3b95bec6b7ac74e04a960015bc9

[GitBox <gi...@apache.org>]

neilcsmith-net commented on a change in pull request #2778:
URL: https://github.com/apache/netbeans/pull/2778#discussion_r581858489



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/DownloadBinaries.java
##########
@@ -478,6 +472,47 @@ public static MavenCoordinate fromGradleFormat(String gradleFormat) {
             }
             return new MavenCoordinate(group, artifact, version, extension, classifier);
         }
+
+        /**
+         * The maven coordinate is supplied in the form:
+         *
+         * <p>{@code m2:/group:name:version:extension:classifier}</p>
+         *
+         * <p>For the DownloadBinaries task the parts group, name and version

Review comment:
       Not sure what the "canonical" format is, but should extension be required, as in https://github.com/apache/netbeans/blob/master/java/maven.embedder/src/org/netbeans/modules/maven/embedder/impl/MavenProtocolHandler.java ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists