You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/08/25 05:13:46 UTC
[GitHub] [druid] gianm opened a new pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
gianm opened a new pull request #10320:
URL: https://github.com/apache/druid/pull/10320
Previously, this was disallowed, because expressions treated multi-values
as nulls. But now, if there's a single multi-value column that can be
mapped over, it's okay to use the index. Expression selectors already do
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10320:
URL: https://github.com/apache/druid/pull/10320#discussion_r476192667
##########
File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java
##########
@@ -226,9 +226,7 @@ public static DimensionSelector makeDimensionSelector(
if (capabilities != null
&& capabilities.getType() == ValueType.STRING
&& capabilities.isDictionaryEncoded().isTrue()
- && !capabilities.hasMultipleValues().isUnknown()
- && !exprDetails.hasInputArrays()
- && !exprDetails.isOutputArray()
+ && canMapOverDictionary(exprDetails, capabilities.hasMultipleValues())
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10320:
URL: https://github.com/apache/druid/pull/10320#issuecomment-680319978
> Is now == 0.19? Or did a patch in master make this possible?
I don't remember the patch offhand, I think it was something @clintropolis had done. I think it's already been released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] julienlafont-tabmo commented on pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
julienlafont-tabmo commented on pull request #10320:
URL: https://github.com/apache/druid/pull/10320#issuecomment-685701450
Quick feedback: We'e seen a huge performance improvement on our requests that where using multi-value columns after this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10320:
URL: https://github.com/apache/druid/pull/10320#issuecomment-680313074
> But now, if there's a single multi-value column that can be
> mapped over, it's okay to use the index.
Is now == 0.19? Or did a patch in master make this possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] julienlafont-tabmo edited a comment on pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
julienlafont-tabmo edited a comment on pull request #10320:
URL: https://github.com/apache/druid/pull/10320#issuecomment-685701450
Quick feedback: We'e seen a huge performance improvement on our queries that where using multi-value columns after this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #10320:
URL: https://github.com/apache/druid/pull/10320#issuecomment-685706582
> Quick feedback: We'e seen a huge performance improvement on our requests that where using multi-value columns after this patch.
Great to hear!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #10320: ExpressionFilter: Use index for expressions of single multi-value columns.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #10320:
URL: https://github.com/apache/druid/pull/10320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org