You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2025/02/05 06:54:19 UTC

[I] Get rid of *.zip in tests cases [airflow]

Lee-W opened a new issue, #46449:
URL: https://github.com/apache/airflow/issues/46449

   ### Description
   
   We should generate the zip file in our test case (i.e., include the files we want to zip but not the zip file itself) and then do the test instead of uploading it to the repo. Currently, we have the following 2 zip files.
   
   * tests/dags/test_dag_warnings.zip
   * tests/dags/test_zip.zip
   
   In addition to it, we should have a pre-commit to avoid someone from commit a zip file.
   
   
   ### Use case/motivation
   
   zip files are hard to review and could incur security issues. 
   
   
   
   ### Related issues
   
   https://github.com/apache/airflow/pull/46231#issuecomment-2630114344
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Get rid of *.zip in tests cases [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W closed issue #46449: Get rid of *.zip in tests cases
URL: https://github.com/apache/airflow/issues/46449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Get rid of *.zip in tests cases [airflow]

Posted by "josix (via GitHub)" <gi...@apache.org>.
josix commented on issue #46449:
URL: https://github.com/apache/airflow/issues/46449#issuecomment-2635870744

   I can take this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org