You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shijinkui <gi...@git.apache.org> on 2016/11/26 07:22:47 UTC

[GitHub] flink pull request #2874: [FLINK-5167] StreamExecutionEnvironment set functi...

GitHub user shijinkui opened a pull request:

    https://github.com/apache/flink/pull/2874

    [FLINK-5167] StreamExecutionEnvironment set function return `this` in\u2026

    StreamExecutionEnvironment's set function return `this` instead of void
    
    for example :
    
    public void setNumberOfExecutionRetries(int numberOfExecutionRetries) { 
      config.setNumberOfExecutionRetries(numberOfExecutionRetries); 
    }
    
    change to:
    
    public StreamExecutionEnvironment setNumberOfExecutionRetries(int numberOfExecutionRetries) { 
      config.setNumberOfExecutionRetries(numberOfExecutionRetries); 
      return this; 
    }
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-5167] StreamExecutionEnvironment's set function return `this` instead of void")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shijinkui/flink FLINK-5166

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2874.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2874
    
----
commit b28992af876c33e00f86d27e1dd6ef783fefa3a0
Author: shijinkui <sh...@huawei.com>
Date:   2016-11-26T06:47:07Z

    [FLINK-5167] StreamExecutionEnvironment set function return `this` instead of void

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2874: [FLINK-5175] StreamExecutionEnvironment's set func...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2874


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2874: [FLINK-5175] StreamExecutionEnvironment's set function re...

Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:

    https://github.com/apache/flink/pull/2874
  
    > Can you add them to this list here? That is where we collect all API-.breaking changes that we want to add.
    
    Done. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2874: [FLINK-5167] StreamExecutionEnvironment set function retu...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2874
  
    @shijinkui I think these changes would be great for Flink 2.0
    
    Can you add them to this list here? That is where we collect all API-.breaking changes that we want to add.
    https://issues.apache.org/jira/browse/FLINK-3957
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2874: [FLINK-5167] StreamExecutionEnvironment set function retu...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2874
  
    The PR changes several `@Public` and `@PublicEvolving` methods. 
    
    We do not touch @Public interfaces for 1.x releases and also try to avoid to modify `@PublicEvolving` interface except for very good reasons. We have a Maven plugin that prevents changes that break the binary compatibility of methods and classes annotated with `@Public`. 
    By building the code before opening a pull request, you can early detect such issues.
    
    I don't think that we can and should merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2874: [FLINK-5167] StreamExecutionEnvironment set function retu...

Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:

    https://github.com/apache/flink/pull/2874
  
    > The PR changes several @Public and @PublicEvolving methods.
    hi, @fhueske 
    Today when set some config, find some function cant't chained one by one. So want to complete all the function needed `return this` conveniently. If chained setting config, the setting will be together, avoid setting config evrywhere.
    
    It's only better used, not important. You can close this. Failed building is noisy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2874: [FLINK-5167] StreamExecutionEnvironment set function retu...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2874
  
    Thanks for the proposal @shijinkui. I agree that the changes might improve the usability a bit for some users. However, the improvements are not significant enough to break the API, IMO.
    
    I'll close this PR and the issue.
    Thanks, Fabian
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---