You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/27 14:27:04 UTC
[jira] [Commented] (MINIFI-279) Make the test class names
consistent
[ https://issues.apache.org/jira/browse/MINIFI-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986709#comment-15986709 ]
ASF GitHub Bot commented on MINIFI-279:
---------------------------------------
GitHub user jzonthemtn opened a pull request:
https://github.com/apache/nifi-minifi/pull/82
MINIFI-279: Makes test classes naming consistent.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jzonthemtn/nifi-minifi MINIFI-279
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
----
> Make the test class names consistent
> ------------------------------------
>
> Key: MINIFI-279
> URL: https://issues.apache.org/jira/browse/MINIFI-279
> Project: Apache NiFi MiNiFi
> Issue Type: Task
> Components: Testing
> Reporter: Jeff Zemerick
> Assignee: Jeff Zemerick
> Priority: Trivial
>
> Some class test classes are named as *Test.java and others are Test*.java. The inconsistent naming can sometimes make it difficult to find the tests for a class. Suggest naming the test classes consistently. There are twice as many classes named *Test.java.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)