You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/05/24 07:34:17 UTC
[kudu-CR](branch-1.17.x) [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19921
to review the following change.
Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
......................................................................
[tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
This patch allows the "kudu wal dump" tool to display auto-incrementing
counter value if present in the WAL segment. It displays the counter
value present in each INSERT/INSERT_IGNORE replicate op and also populates
the corresponding auto incrementing column values for each row when
printing rows.
Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Reviewed-on: http://gerrit.cloudera.org:8080/19698
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
3 files changed, 171 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/19921/1
--
To view, visit http://gerrit.cloudera.org:8080/19921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.17.x) [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19921 )
Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
......................................................................
Patch Set 1: Verified+1
unrelated test failure in LogRollingITest.TestLogCleanupOnStartup
--
To view, visit http://gerrit.cloudera.org:8080/19921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 May 2023 14:32:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19921 )
Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 May 2023 14:31:59 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19921 )
Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
......................................................................
[tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump
This patch allows the "kudu wal dump" tool to display auto-incrementing
counter value if present in the WAL segment. It displays the counter
value present in each INSERT/INSERT_IGNORE replicate op and also populates
the corresponding auto incrementing column values for each row when
printing rows.
Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Reviewed-on: http://gerrit.cloudera.org:8080/19698
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/19921
---
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
3 files changed, 171 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e807aaef48683ec7c5317eecdedf8e6e15950e2
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>