You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/20 06:55:29 UTC
[GitHub] [kafka] JoeCqupt opened a new pull request #11089: MINOR: remove unnecessary judgment
JoeCqupt opened a new pull request #11089:
URL: https://github.com/apache/kafka/pull/11089
remove unnecessary judgment in method AdminUtils::assignReplicasToBrokersRackAware
because replicationFactor <= numBrokers , so the judgment is not unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt commented on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware
Posted by GitBox <gi...@apache.org>.
JoeCqupt commented on pull request #11089:
URL: https://github.com/apache/kafka/pull/11089#issuecomment-896475447
@ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt commented on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware
Posted by GitBox <gi...@apache.org>.
JoeCqupt commented on pull request #11089:
URL: https://github.com/apache/kafka/pull/11089#issuecomment-884671155
call for review @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt edited a comment on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware
Posted by GitBox <gi...@apache.org>.
JoeCqupt edited a comment on pull request #11089:
URL: https://github.com/apache/kafka/pull/11089#issuecomment-884671155
call for review @ijuma @guozhangwang @hachikuji @mjsax @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt edited a comment on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware
Posted by GitBox <gi...@apache.org>.
JoeCqupt edited a comment on pull request #11089:
URL: https://github.com/apache/kafka/pull/11089#issuecomment-884671155
call for review @ijuma @guozhangwang @hachikuji @mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11089: MINOR: remove unnecessary judgment in AdminUtils::assignReplicasToBrokersRackAware
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11089:
URL: https://github.com/apache/kafka/pull/11089#issuecomment-885410437
Overall looks good to me. Just one qq: do we always guarantee `replicationFactor <= numBrokers`? I know we check and forbid it when creating a new topic, but after a topic is created, if we shutdown brokers and reassign replicas, would we stop with less replicas and warn users?
cc @ijuma for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org