You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/04/03 05:21:02 UTC

[GitHub] [netbeans] junichi11 opened a new pull request, #5767: Avoid showing invalid types in the Fix Imports panel

junichi11 opened a new pull request, #5767:
URL: https://github.com/apache/netbeans/pull/5767

   Ignore the following cases
   
   - `array<int, TypeName>`
   - `array{'key': TypeName}`
   
   #### Example
   
   ```php
   <?php
   namespace Test1;
   
   class Foo {
       
   }
   
   namespace Test2;
   
   class Test
   {
       /**
        * @param array<'foo', Foo> $param
        */
       public function test1(array $param): Foo {
           return $param['foo'];
       }
   
       /**
        * @param array{'foo': Foo, "bar": string} $param
        */
       public function test2(array $param): Foo {
           return $param['foo'];
       }
   }
   
   ```
   
   #### Before:
   ![nb-php-avoid-showing-invalid-type-in-fix-imports-panel-before](https://user-images.githubusercontent.com/738383/229417216-38c22073-fe1d-49fa-b57c-1e7a188dcf28.png)
   
   
   #### After:
   ![nb-php-avoid-showing-invalid-type-in-fix-imports-panel-after](https://user-images.githubusercontent.com/738383/229417222-0d8171b5-c261-45f6-b368-4327a18f9889.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #5767: Avoid showing invalid types in the Fix Imports panel

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik merged PR #5767:
URL: https://github.com/apache/netbeans/pull/5767


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] zeleznypa commented on pull request #5767: Avoid showing invalid types in the Fix Imports panel

Posted by "zeleznypa (via GitHub)" <gi...@apache.org>.
zeleznypa commented on PR #5767:
URL: https://github.com/apache/netbeans/pull/5767#issuecomment-1495663297

   ❤️🙇‍♂️👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #5767: Avoid showing invalid types in the Fix Imports panel

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5767:
URL: https://github.com/apache/netbeans/pull/5767#issuecomment-1493683752

   NOTE: This is related to #4614 
   The following cases is not supported yet.
   - `array<int, TypeName>`
   - `array{'key': TypeName}`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists