You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "baumgold (via GitHub)" <gi...@apache.org> on 2023/06/12 23:20:28 UTC

[GitHub] [arrow-julia] baumgold commented on pull request #464: Formatting

baumgold commented on PR #464:
URL: https://github.com/apache/arrow-julia/pull/464#issuecomment-1588239678

   > I think this is mostly great and I agree we should do it. I think the only change I'm really against is removing spaces around operators, regardless of where or what kind of clause they occur in. I also personally prefer keeping spaces around the `<:` operator in type parameter clauses, but I don't feel as strongly about that if people prefer otherwise.
   
   I believe the only control for this that we are given in JuliaFormatter is the following:
   
   https://github.com/domluna/JuliaFormatter.jl#whitespace_ops_in_indices
   
   I overrode the default from false to true.  That seems like it should mostly fix this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org