[jira] [Commented] (PARQUET-1600) Fix shebang in parquet-benchmarks/run.sh

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864925#comment-16864925 ] 

ASF GitHub Bot commented on PARQUET-1600:
-----------------------------------------

sekikn commented on pull request #651: PARQUET-1600: Fix shebang in parquet-benchmarks/run.sh
URL: https://github.com/apache/parquet-mr/pull/651
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-1600
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No additional test since it's a really minor change. I ran the modified script via tcsh and confirmed that it worked as expected.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix shebang in parquet-benchmarks/run.sh
> ----------------------------------------
>
>                 Key: PARQUET-1600
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1600
>             Project: Parquet
>          Issue Type: Bug
>            Reporter: Kengo Seki
>            Priority: Minor
>              Labels: pull-request-available
>
> The following shebang does not work as expected since it's not on the first line and there's a space between # and !.
> {code:title=parquet-benchmarks/run.sh}
> (snip)
> # !/usr/bin/env bash
> {code}
> For example, if users use tcsh, it fails as follows:
> {code}
> > parquet-benchmarks/run.sh
> Illegal variable name.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)