You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/05 08:00:21 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1024: HDDS-3720. Datanode configuration object has wrong values

adoroszlai opened a new pull request #1024:
URL: https://github.com/apache/hadoop-ozone/pull/1024


   ## What changes were proposed in this pull request?
   
   1. `@Config` annotation was assigned to the wrong fields (the ones with default values) in `DatanodeConfiguration` - fixed.
   2. Added check for possible coding error: `@Config` on `final` field.  This catches the above problem if the class is instantiated in tests.
   3. Added unit test.
   
   https://issues.apache.org/jira/browse/HDDS-3720
   
   ## How was this patch tested?
   
   1. Verified that default values are used (without warning) by default:
   
   ```
   datanode_1  | ... INFO statemachine.DatanodeStateMachine: container.delete.threads: 2
   datanode_1  | ... INFO statemachine.DatanodeStateMachine: replication.streams.limit: 10
   ```
   
   2. Verified that valid custom values are accepted:
   
   ```
   datanode_1  | ... INFO statemachine.DatanodeStateMachine: container.delete.threads: 123
   datanode_1  | ... INFO statemachine.DatanodeStateMachine: replication.streams.limit: 42
   ```
   
   3. Verified that invalid custom values produce warnings, and config is reset to default:
   
   ```
   datanode_1  | ... WARN statemachine.DatanodeConfiguration: hdds.datanode.replication.streams.limit must be greater than zero and was set to 0. Defaulting to 10
   datanode_1  | ... WARN statemachine.DatanodeConfiguration: hdds.datanode.container.delete.threads.max must be greater than zero and was set to -1. Defaulting to 2
   datanode_1  | ... INFO statemachine.DatanodeStateMachine: container.delete.threads: 2
   datanode_1  | ... INFO statemachine.DatanodeStateMachine: replication.streams.limit: 10
   ```
   
   Added unit test for the same cases.
   
   https://github.com/adoroszlai/hadoop-ozone/runs/741212448


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] nandakumar131 commented on pull request #1024: HDDS-3720. Datanode configuration object has wrong values

Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on pull request #1024:
URL: https://github.com/apache/hadoop-ozone/pull/1024#issuecomment-639532021


   Thanks @adoroszlai for the contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1024: HDDS-3720. Datanode configuration object has wrong values

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1024:
URL: https://github.com/apache/hadoop-ozone/pull/1024#issuecomment-639532326


   Thanks @nandakumar131 for reviewing and committing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] nandakumar131 merged pull request #1024: HDDS-3720. Datanode configuration object has wrong values

Posted by GitBox <gi...@apache.org>.
nandakumar131 merged pull request #1024:
URL: https://github.com/apache/hadoop-ozone/pull/1024


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org