You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2019/01/11 19:14:26 UTC
[GitHub] [geode] PurelyApplied opened pull request #3067: GEODE-6259:
Correct issues with publish targets
* Default values in gradle.properties should not be quote-wrapped
* Short-circuit-when-exists operator is ?: in Groovy, not || like in Python.
* Username/Password credentials are only valid for maven targets of HTTP, HTTPS, and SFTP.
* The meta pipeline should be updated when meta.properties changes.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3067 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #3067:
GEODE-6259: Correct issues with publish targets
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
@pivotal-jbarrett Yep, you were exactly right. For preference, the [referenced documentation](https://docs.gradle.org/current/userguide/repository_types.html) specifies credentials should be set for HTTP, HTTPS, and SFTP, so I went with an opt-in rather than a "not-GCS" style here.
[ Full content available at: https://github.com/apache/geode/pull/3067 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied closed pull request #3067: GEODE-6259:
Correct issues with publish targets
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/3067 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org