You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/11/01 00:28:45 UTC
[Impala-ASF-CR] Add query id debugging for HS2
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14607
Change subject: Add query id debugging for HS2
......................................................................
Add query id debugging for HS2
As part of debugging IMPALA-9098, I realised we don't print the query ID
for HS2 queries, which makes it harder finding queries in the logs.
This pulls the query ID out of the Impyla handle and prints it in
the expected form (I used the same logic as in impala shell).
Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
---
M tests/common/impala_connection.py
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/14607/1
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Add query id debugging for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14607 )
Change subject: Add query id debugging for HS2
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5189/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 18:55:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add query id debugging for HS2
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14607 )
Change subject: Add query id debugging for HS2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 18:46:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add query id debugging for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14607 )
Change subject: Add query id debugging for HS2
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 18:55:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add query id debugging for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14607 )
Change subject: Add query id debugging for HS2
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4924/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 01:13:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add query id debugging for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14607 )
Change subject: Add query id debugging for HS2
......................................................................
Add query id debugging for HS2
As part of debugging IMPALA-9098, I realised we don't print the query ID
for HS2 queries, which makes it harder finding queries in the logs.
This pulls the query ID out of the Impyla handle and prints it in
the expected form (I used the same logic as in impala shell).
Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Reviewed-on: http://gerrit.cloudera.org:8080/14607
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_connection.py
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Add query id debugging for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14607 )
Change subject: Add query id debugging for HS2
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d34128a7a2b69ca9043fcf5e919e9dd2a9f452b
Gerrit-Change-Number: 14607
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 23:17:21 +0000
Gerrit-HasComments: No