You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2007/05/21 21:10:48 UTC

svn commit: r540244 - /incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/jcas/cas/Sofa.java

Author: schor
Date: Mon May 21 12:10:47 2007
New Revision: 540244

URL: http://svn.apache.org/viewvc?view=rev&rev=540244
Log:
[UIMA-409] Using new Sofa(...) constructor failed to create a corresponding view, which
could lead to failures when the CAS was reset.  Also - added comment to clarify meaning
of poorly named feature (design changed after the feature was set in stone).

Modified:
    incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/jcas/cas/Sofa.java

Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/jcas/cas/Sofa.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/jcas/cas/Sofa.java?view=diff&rev=540244&r1=540243&r2=540244
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/jcas/cas/Sofa.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/jcas/cas/Sofa.java Mon May 21 12:10:47 2007
@@ -80,6 +80,7 @@
 		super(jcas);
 		final CASImpl casImpl = jcasType.casImpl;
 		casImpl.addSofa(casImpl.createFS(this.addr), ID.getSofaID(), mimeType);
+    casImpl.getView(this); // needed to make reset work
 	}
 
 	/**
@@ -93,7 +94,7 @@
 
 	// *--------------*
 	// * Feature: sofaNum
-
+  // ** Note: this gets the same feature, sofaNum, as getSofaRef, below
 	/**
    * getter for sofaNum - gets
    * 
@@ -250,6 +251,7 @@
 	}
 
 	// This method is duplicated in SofaFSImpl. Any changes should be made in both places.
+  // ** Note: this gets the feature named "sofaNum"
 	public int getSofaRef() {
 		final Feature numFeat = jcasType.casImpl.getTypeSystem().getFeatureByFullName(
 				CAS.FEATURE_FULL_NAME_SOFANUM);