You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/06 05:44:25 UTC
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request #1521: wireless: gs2200m: Add flags member
SPRESENSE opened a new pull request #1521:
URL: https://github.com/apache/incubator-nuttx/pull/1521
## Summary
Add flags member to take recv() flags from daemon.
## Impact
## Testing
not tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1521: wireless: gs2200m: Add flags member
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1521:
URL: https://github.com/apache/incubator-nuttx/pull/1521#discussion_r466188978
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -116,6 +116,7 @@ struct gs2200m_recv_msg
FAR uint8_t *buf;
uint16_t len; /* actual buffer length */
uint16_t reqlen; /* requested size */
+ int32_t flags; /* MSG_* flags */
Review comment:
should we have code manipulate the new field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #1521: wireless: gs2200m: Add flags member
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #1521:
URL: https://github.com/apache/incubator-nuttx/pull/1521#discussion_r466216695
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -116,6 +116,7 @@ struct gs2200m_recv_msg
FAR uint8_t *buf;
uint16_t len; /* actual buffer length */
uint16_t reqlen; /* requested size */
+ int32_t flags; /* MSG_* flags */
Review comment:
@SPRESENSE, @xiaoxiang781216
The field will be used in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #1521: wireless: gs2200m: Add flags member
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #1521:
URL: https://github.com/apache/incubator-nuttx/pull/1521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on a change in pull request #1521: wireless: gs2200m: Add flags member
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on a change in pull request #1521:
URL: https://github.com/apache/incubator-nuttx/pull/1521#discussion_r466213539
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -116,6 +116,7 @@ struct gs2200m_recv_msg
FAR uint8_t *buf;
uint16_t len; /* actual buffer length */
uint16_t reqlen; /* requested size */
+ int32_t flags; /* MSG_* flags */
Review comment:
Yes, but not now. I want to leave it to @masayuki2009 .
This patch is needed for prevent build break by daemon patches (in apps), I'll create it after this patch is getting merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org