You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/01/19 12:13:45 UTC
Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to automate
patch upload process
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2796
https://issues.apache.org/jira/browse/SQOOP-2796
Repository: sqoop-sqoop2
Description
-------
Our process to submit a contribution to Sqoop has quite a few steps:
# Clone repo
# Work on the fix/feature/...
# Generate text patch
# Upload it to review board
# Don't forget to publish the review board
# Upload the patch to JIRA
# Switch the JIRA to "Patch available"
Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
Diffs
-----
dev-support/upload-patch.py PRE-CREATION
Diff: https://reviews.apache.org/r/42495/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115521
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Fine
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Jarek Cecho <ja...@apache.org>.
> On Jan. 19, 2016, 6:52 p.m., Abraham Fine wrote:
> > dev-support/upload-patch.py, line 194
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line194>
> >
> > i name my git branches after the jira. i imagine i am not the only one. couldn't we try to get the jira from the branch name?
That's good suggestion - would you mind if I'll do that in subsequent JIRA?
> On Jan. 19, 2016, 6:52 p.m., Abraham Fine wrote:
> > dev-support/upload-patch.py, line 226
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line226>
> >
> > perhaps it should be an option to make the changes public by default rather than just doing it.
I was thinking about this one myself. The reason why I did not do it at this point is that the scripts is straighforward. Generate patch -> upload to review board -> update JIRA. If the review haven't been published, then it doesn't make sense to continue in the next steps. Perhaps we can do "review board only" mode, would that be helpful?
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115211
-----------------------------------------------------------
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Abraham Fine <ab...@abrahamfine.com>.
> On Jan. 19, 2016, 6:52 p.m., Abraham Fine wrote:
> > dev-support/upload-patch.py, line 226
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line226>
> >
> > perhaps it should be an option to make the changes public by default rather than just doing it.
>
> Jarek Cecho wrote:
> I was thinking about this one myself. The reason why I did not do it at this point is that the scripts is straighforward. Generate patch -> upload to review board -> update JIRA. If the review haven't been published, then it doesn't make sense to continue in the next steps. Perhaps we can do "review board only" mode, would that be helpful?
i agree, since we are uploading the new patch to jira it does not make sense to prevent rb from being made visisble.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115211
-----------------------------------------------------------
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Jarek Cecho <ja...@apache.org>.
> On Jan. 19, 2016, 6:52 p.m., Abraham Fine wrote:
> > dev-support/upload-patch.py, line 194
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line194>
> >
> > i name my git branches after the jira. i imagine i am not the only one. couldn't we try to get the jira from the branch name?
>
> Jarek Cecho wrote:
> That's good suggestion - would you mind if I'll do that in subsequent JIRA?
https://issues.apache.org/jira/browse/SQOOP-2799
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115211
-----------------------------------------------------------
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115211
-----------------------------------------------------------
dev-support/upload-patch.py (line 194)
<https://reviews.apache.org/r/42495/#comment176114>
i name my git branches after the jira. i imagine i am not the only one. couldn't we try to get the jira from the branch name?
dev-support/upload-patch.py (line 226)
<https://reviews.apache.org/r/42495/#comment176115>
perhaps it should be an option to make the changes public by default rather than just doing it.
- Abraham Fine
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Abraham Fine <ab...@abrahamfine.com>.
> On Jan. 20, 2016, 2:30 a.m., Colin Ma wrote:
> > dev-support/upload-patch.py, line 168
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line168>
> >
> > The patch name is the same, add some suffix will be easy to find the lastest one.
> > For example, in SQOOP-2792, all patches have the same name and the update time is yesterday, I don't know which one should be used.
>
> Jarek Cecho wrote:
> This is actually something that JIRA itself is solving for us - all "older" files have greyed out name whereas only the "most up to date" variant is blue (and that is the one that should be used).
>
> I've heard this concern a few times already though, so I guess that people are not aware of this "feature". Perhaps we should improve it to make it easier for everyone. Would you mind doing that as part of separate JIRA though?
don't we already get this kind of thing through the review board revision history?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115320
-----------------------------------------------------------
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Jarek Cecho <ja...@apache.org>.
> On Jan. 20, 2016, 2:30 a.m., Colin Ma wrote:
> > dev-support/upload-patch.py, line 168
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line168>
> >
> > The patch name is the same, add some suffix will be easy to find the lastest one.
> > For example, in SQOOP-2792, all patches have the same name and the update time is yesterday, I don't know which one should be used.
This is actually something that JIRA itself is solving for us - all "older" files have greyed out name whereas only the "most up to date" variant is blue (and that is the one that should be used).
I've heard this concern a few times already though, so I guess that people are not aware of this "feature". Perhaps we should improve it to make it easier for everyone. Would you mind doing that as part of separate JIRA though?
> On Jan. 20, 2016, 2:30 a.m., Colin Ma wrote:
> > dev-support/upload-patch.py, line 273
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line273>
> >
> > It will be better to add a link to review board in JIRA.
The scripts already updates JIRA with the link to the review board (just on different place).
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115320
-----------------------------------------------------------
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115320
-----------------------------------------------------------
dev-support/upload-patch.py (line 168)
<https://reviews.apache.org/r/42495/#comment176290>
The patch name is the same, add some suffix will be easy to find the lastest one.
For example, in SQOOP-2792, all patches have the same name and the update time is yesterday, I don't know which one should be used.
dev-support/upload-patch.py (line 273)
<https://reviews.apache.org/r/42495/#comment176289>
It will be better to add a link to review board in JIRA.
- Colin Ma
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to
automate patch upload process
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115531
-----------------------------------------------------------
Ship it!
Ship It!
- Colin Ma
On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 11:13 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2796
> https://issues.apache.org/jira/browse/SQOOP-2796
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Our process to submit a contribution to Sqoop has quite a few steps:
>
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
>
> Forgetting to do any of those steps will lead to a quite unnecessary delays with accepting the patch so I would like to automate steps 3-7 with simple script that one can call from the computer and all that will happen "magically" automatically.
>
>
> Diffs
> -----
>
> dev-support/upload-patch.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42495/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>