You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/24 21:27:52 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #5330: Switch to Sqitch - Sqitch DB management proof-of-concept
ocket8888 opened a new pull request #5330:
URL: https://github.com/apache/trafficcontrol/pull/5330
This should never be merged. It breaks CDN-in-a-Box and TO and TP in general. That's because it adds a sample migration to change DS Active properties from a boolean to an enum. The tests run only far enough to prove that the database changes take place properly.
This PR changes he DB management system from the abandoned Goose project to one recommended by PostgreSQL itself: Sqitch.
With Sqitch, you don't need to worry about naming your files with a timestamp, or ensuring they have right precision or even that they run in the right order - dependencies are explicit and the plan file keeps track of them, and it allows you to write verification queries to test that your changes really worked. This PR includes one such test for the migration it includes. It also provides functionality akin to the `admin.go` utility out-of-the-box - although this PR also updates that utility to use Sqitch migrations when provided the `--use-sqitch` option-argument on the command-line.
For more information about Sqitch, refer to https://sqitch.org
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #5330: Switch to Sqitch - Sqitch DB management proof-of-concept
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #5330:
URL: https://github.com/apache/trafficcontrol/pull/5330#issuecomment-733258697
Where does PostgreSQL recommend this? I'm curious to know why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5330: Switch to Sqitch - Sqitch DB management proof-of-concept
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5330:
URL: https://github.com/apache/trafficcontrol/pull/5330#issuecomment-733262541
They list a bunch of suggested tools on [their wiki page about them](https://wiki.postgresql.org/wiki/Change_management_tools_and_techniques) - this is just one such tool. The one I like the most.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5330: Switch to Sqitch - Sqitch DB management proof-of-concept
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5330:
URL: https://github.com/apache/trafficcontrol/pull/5330#issuecomment-900267268
We moved to Migrate instead - I still like Sqitch better, but at this point it seems this PR has been superseded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed pull request #5330: Switch to Sqitch - Sqitch DB management proof-of-concept
Posted by GitBox <gi...@apache.org>.
ocket8888 closed pull request #5330:
URL: https://github.com/apache/trafficcontrol/pull/5330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org