You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by kinow <gi...@git.apache.org> on 2017/09/12 11:22:40 UTC

[GitHub] commons-collections pull request #26: COLLECTIONS-656 Update commons-parent ...

GitHub user kinow opened a pull request:

    https://github.com/apache/commons-collections/pull/26

    COLLECTIONS-656 Update commons-parent version, and use inherited FindBugs plugin version

    Copied settings from [text] component after Javadocs issues were fixed but then the `mvn site` command failed in the FindBugs reporting.
    
    With this change, `mvn clean site` works with Java 8, and produces the correct site reports.
    
    Created the ticket and this pull request to wait for feedback & reviews in case there's any issue associated with upgrading the commons-parent version (there's none in this case as far as I can tell).
    
    Feel free to comment here or merge the pull request (and add changes.xml entry...) in case you know there is nothing wrong in updating the commons-parent version.
    
    Thanks
    Bruno

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/commons-collections COLLECTIONS-656

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit c6996173991d0c5a311e0d8f6d68d98ca4749d85
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date:   2017-09-12T11:19:18Z

    COLLECTIONS-656 Update commons-parent version, and use inherited FindBugs plugin version

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-collections issue #26: COLLECTIONS-656 Update commons-parent version...

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:

    https://github.com/apache/commons-collections/pull/26
  
    Fixed in 1081b725bea339fcda33d70c71b9eb1859d60d8f and 6a10051a7b5b3c615180413fe116c61780754969. Thanks to @garydgregory !


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-collections pull request #26: COLLECTIONS-656 Update commons-parent ...

Posted by kinow <gi...@git.apache.org>.
Github user kinow closed the pull request at:

    https://github.com/apache/commons-collections/pull/26


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[GitHub] commons-collections issue #26: COLLECTIONS-656 Update commons-parent version...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/commons-collections/pull/26
  
    
    [![Coverage Status](https://coveralls.io/builds/13232186/badge)](https://coveralls.io/builds/13232186)
    
    Coverage increased (+0.02%) to 85.138% when pulling **c6996173991d0c5a311e0d8f6d68d98ca4749d85 on kinow:COLLECTIONS-656** into **29d2e93966e7fb99a888a58ab43480e485dcdfc6 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org