You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ramkumar Aiyengar (JIRA)" <ji...@apache.org> on 2016/01/11 11:37:39 UTC

[jira] [Commented] (SOLR-7683) Introduce support to identify Solr internal request types

    [ https://issues.apache.org/jira/browse/SOLR-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091751#comment-15091751 ] 

Ramkumar Aiyengar commented on SOLR-7683:
-----------------------------------------

Thanks [~hgadre]..

bq. In case of DirectXmlRequest, we don't know the actual type of request until after the object is created (and hence the value can not be hardcoded). Also since existing clients/applications may be using this class, it may not a good idea to enforce the requirement to specify a type. Hence may be we should keep "Unspecified" type for backwards compatibility?

We should keep backward compatibility for 5x, but could break it in trunk if it takes us forward. [~ryantxu], [~shalinmangar], this seems to be hardly used/touched in the last eight years (asking since you guys seem to have dealt with it years back), and is only internally used by DIH -- but is a public interface. Is there any value in keeping it any longer? If not, I would propose just repurposing it as {{DIHRequest}} in trunk, else we could add a type..

bq. The other thing is we need to make sure that for server <-> server communication, we are using the "server" context. Since we are creating HttpSolrClient instances at number of places, we need to figure out a good way to implement this. I propose that we should use a factory pattern for this. i.e. we should define two factory implementations each dedicated for a specific use-case (e.g. as a client or as a server) and refactor the code to use them appropriately. This may involve considerable amount of refactoring. But the resulting code would be clean and extensible for future requirements.

+1


> Introduce support to identify Solr internal request types
> ---------------------------------------------------------
>
>                 Key: SOLR-7683
>                 URL: https://issues.apache.org/jira/browse/SOLR-7683
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: Hrishikesh Gadre
>            Assignee: Ramkumar Aiyengar
>         Attachments: SOLR-7683.patch, SOLR-7683.patch
>
>
> SOLR-7344 is introducing support to partition the Jetty worker pool to enforce the number of concurrent requests for various types (e.g. Internal_Querying, Internal_Indexing, External etc.). For this we need to identify requests sent between Solr servers and their types (i.e. Querying/Indexing etc.).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org