You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicemix.apache.org by ff...@apache.org on 2013/10/18 15:54:59 UTC

svn commit: r1533454 - in /servicemix/components/trunk: ./ bindings/servicemix-cxf-bc/ bindings/servicemix-cxf-bc/src/main/java/org/apache/servicemix/cxfbc/ bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/ bindings/se...

Author: ffang
Date: Fri Oct 18 13:54:59 2013
New Revision: 1533454

URL: http://svn.apache.org/r1533454
Log:
[SMXCOMP-974]Upgrade to CXF 2.7.6

Modified:
    servicemix/components/trunk/bindings/servicemix-cxf-bc/pom.xml
    servicemix/components/trunk/bindings/servicemix-cxf-bc/src/main/java/org/apache/servicemix/cxfbc/CxfBcConsumer.java
    servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/CxfBcAddressingTest.java
    servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/HeaderVerifier.java
    servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/rm/CxfBcRMSequenceTest.java
    servicemix/components/trunk/engines/servicemix-cxf-se/pom.xml
    servicemix/components/trunk/pom.xml

Modified: servicemix/components/trunk/bindings/servicemix-cxf-bc/pom.xml
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/bindings/servicemix-cxf-bc/pom.xml?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/bindings/servicemix-cxf-bc/pom.xml (original)
+++ servicemix/components/trunk/bindings/servicemix-cxf-bc/pom.xml Fri Oct 18 13:54:59 2013
@@ -359,6 +359,12 @@
             <groupId>org.apache.servicemix</groupId>
             <artifactId>servicemix-utils</artifactId>
             <scope>provided</scope>
+            <exclusions>
+                <exclusion>
+                    <groupId>net.sf.ehcache</groupId>
+                    <artifactId>ehcache</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>
         <dependency>
             <groupId>org.apache.servicemix.specs</groupId>

Modified: servicemix/components/trunk/bindings/servicemix-cxf-bc/src/main/java/org/apache/servicemix/cxfbc/CxfBcConsumer.java
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/bindings/servicemix-cxf-bc/src/main/java/org/apache/servicemix/cxfbc/CxfBcConsumer.java?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/bindings/servicemix-cxf-bc/src/main/java/org/apache/servicemix/cxfbc/CxfBcConsumer.java (original)
+++ servicemix/components/trunk/bindings/servicemix-cxf-bc/src/main/java/org/apache/servicemix/cxfbc/CxfBcConsumer.java Fri Oct 18 13:54:59 2013
@@ -40,6 +40,7 @@ import javax.wsdl.extensions.soap.SOAPBi
 import javax.xml.namespace.QName;
 import javax.xml.transform.Source;
 
+import org.apache.cxf.feature.Feature;
 import org.w3c.dom.Element;
 import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
@@ -580,7 +581,7 @@ public class CxfBcConsumer extends Consu
     private void addRMFeatureRequiredInterceptors() {
         CXFBusImpl bus = (CXFBusImpl) getBus();
         if (bus.getFeatures() != null) {
-            for (AbstractFeature feature : bus.getFeatures()){
+            for (Feature feature : bus.getFeatures()){
                 if (feature.getClass().getName().equals("org.apache.cxf.ws.rm.feature.RMFeature")) {
                     bus.getOutInterceptors().add(new BareOutInterceptor());
                 }

Modified: servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/CxfBcAddressingTest.java
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/CxfBcAddressingTest.java?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/CxfBcAddressingTest.java (original)
+++ servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/CxfBcAddressingTest.java Fri Oct 18 13:54:59 2013
@@ -343,7 +343,8 @@ public class CxfBcAddressingTest extends
      */
     protected static String verifyHeaders(List<String> wsaHeaders,
                                           boolean partial,
-                                          boolean requestLeg) {
+                                          boolean requestLeg,
+                                          boolean replyToRequired) {
         
         String ret = null;
         if (!wsaHeaders.contains(Names.WSA_MESSAGEID_NAME)) {
@@ -353,13 +354,15 @@ public class CxfBcAddressingTest extends
             ret = "expected To header";
         }
        
-        if (!(wsaHeaders.contains(Names.WSA_REPLYTO_NAME)
-              || wsaHeaders.contains(Names.WSA_RELATESTO_NAME))) {
+        if (replyToRequired 
+            && !(wsaHeaders.contains(Names.WSA_REPLYTO_NAME)
+                || wsaHeaders.contains(Names.WSA_RELATESTO_NAME))) {
             ret = "expected ReplyTo or RelatesTo header";
         }
+        /*
         if (partial) { 
             if (!wsaHeaders.contains(Names.WSA_FROM_NAME)) {
-                //ret = "expected From header";
+                ret = "expected From header";
             }
         } else {
             // REVISIT Action missing from full response
@@ -367,6 +370,7 @@ public class CxfBcAddressingTest extends
             //    ret = "expected Action header";
             //}            
         }
+        */
         if (requestLeg && !(wsaHeaders.contains(CUSTOMER_NAME.getLocalPart()))) {
             ret = "expected CustomerKey header";
         }

Modified: servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/HeaderVerifier.java
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/HeaderVerifier.java?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/HeaderVerifier.java (original)
+++ servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/addressing/HeaderVerifier.java Fri Oct 18 13:54:59 2013
@@ -37,6 +37,8 @@ import org.apache.cxf.binding.soap.SoapV
 import org.apache.cxf.binding.soap.interceptor.AbstractSoapInterceptor;
 import org.apache.cxf.headers.Header;
 import org.apache.cxf.helpers.DOMUtils;
+import org.apache.cxf.interceptor.Fault;
+import org.apache.cxf.message.MessageUtils;
 import org.apache.cxf.phase.Phase;
 import org.apache.cxf.ws.addressing.AddressingProperties;
 import org.apache.cxf.ws.addressing.AttributedURIType;
@@ -60,11 +62,25 @@ public class HeaderVerifier extends Abst
         super(Phase.POST_PROTOCOL);
     }
     
+    public HeaderVerifier(String s) {
+        super(s);
+    }
+    
     public Set<QName> getUnderstoodHeaders() {
         return Names.HEADERS;
     }
 
     public void handleMessage(SoapMessage message) {
+        if (!MessageUtils.isRequestor(message)
+            && !MessageUtils.isOutbound(message)
+            && getPhase().equals(Phase.POST_PROTOCOL)) {
+            message.getInterceptorChain().add(new AbstractSoapInterceptor(Phase.UNMARSHAL) {
+                public void handleMessage(SoapMessage message) throws Fault {
+                    mediate(message);
+                }                
+            });
+            return;
+        }
         mediate(message);
     }
 
@@ -128,7 +144,10 @@ public class HeaderVerifier extends Abst
                                       || outgoingPartialResponse;
             verificationCache.put(CxfBcAddressingTest.verifyHeaders(wsaHeaders, 
                                                         partialResponse,
-                                                        isRequestLeg(message)));
+                                                        isRequestLeg(message),
+                                                        false));
+            
+                                                                   
         } catch (SOAPException se) {
             verificationCache.put("SOAP header verification failed: " + se);
         }
@@ -152,6 +171,20 @@ public class HeaderVerifier extends Abst
                             wsaHeaders.add(hdr.getLocalName());
                         }
                     }
+                
+                }
+            } else if (obj instanceof JAXBElement) {
+                JAXBElement<?> el = (JAXBElement<?>)obj;
+                if (namespaceURI.equals(el.getName().getNamespaceURI())) {
+                    if (namespaceURI.endsWith("addressing")) {
+                        currentNamespaceURI = namespaceURI;
+                        wsaHeaders.add(el.getName().getLocalPart());
+                    } else if (CxfBcAddressingTest.CUSTOMER_NAME.getNamespaceURI().equals(namespaceURI)) {
+                        String headerText = (String)el.getValue();
+                        if (CxfBcAddressingTest.CUSTOMER_KEY.equals(headerText)) {
+                            wsaHeaders.add(el.getName().getLocalPart());
+                        }
+                    }
                 }
             }
             

Modified: servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/rm/CxfBcRMSequenceTest.java
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/rm/CxfBcRMSequenceTest.java?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/rm/CxfBcRMSequenceTest.java (original)
+++ servicemix/components/trunk/bindings/servicemix-cxf-bc/src/test/java/org/apache/servicemix/cxfbc/ws/rm/CxfBcRMSequenceTest.java Fri Oct 18 13:54:59 2013
@@ -20,7 +20,6 @@ import java.io.IOException;
 import java.math.BigInteger;
 import java.net.URL;
 import java.util.ArrayList;
-import java.util.Iterator;
 import java.util.List;
 import java.util.concurrent.Executor;
 import java.util.concurrent.Executors;
@@ -68,6 +67,8 @@ public class CxfBcRMSequenceTest extends
     private static final String GREETMEONEWAY_ACTION = "http://cxf.apache.org/greeter_control/Greeter/greetMeOneWayRequest";
     private static final String GREETME_ACTION = "http://cxf.apache.org/greeter_control/Greeter/greetMeRequest";
     private static final String GREETME_RESPONSE_ACTION = "http://cxf.apache.org/greeter_control/Greeter/greetMeResponse";
+    private static final String RM10_GENERIC_FAULT_ACTION 
+            = "http://schemas.xmlsoap.org/ws/2004/08/addressing/fault";
     private static final QName CONTROL_SERVICE = new QName("http://cxf.apache.org/greeter_control", "ControlService");
     private static final QName GREETER_SERVICE = new QName("http://cxf.apache.org/greeter_control", "GreeterService");
 
@@ -168,10 +169,10 @@ public class CxfBcRMSequenceTest extends
 
         greeterBus = bf.createBus("org/apache/servicemix/cxfbc/ws/rm/rminterceptors.xml");
         BusFactory.setDefaultBus(greeterBus);
-        removeRMInterceptors(greeterBus.getOutInterceptors());
+        /*removeRMInterceptors(greeterBus.getOutInterceptors());
         removeRMInterceptors(greeterBus.getOutFaultInterceptors());
         removeRMInterceptors(greeterBus.getInInterceptors());
-        removeRMInterceptors(greeterBus.getInFaultInterceptors());
+        removeRMInterceptors(greeterBus.getInFaultInterceptors());*/
         LOG.fine("Initialised greeter bus with addressing but without RM interceptors");
 
         outRecorder = new OutMessageRecorder();
@@ -702,7 +703,7 @@ public class CxfBcRMSequenceTest extends
 
         mf.verifyMessages(3, false);
         expectedActions = new String[] {RM10Constants.INSTANCE.getCreateSequenceResponseAction(),
-                                        GREETME_RESPONSE_ACTION, null};
+                                        GREETME_RESPONSE_ACTION, RM10_GENERIC_FAULT_ACTION};
         mf.verifyActions(expectedActions, false);
         mf.verifyMessageNumbers(new String[] {null, "1", null}, false);
         mf.verifyAcknowledgements(new boolean[3] , false);
@@ -802,7 +803,7 @@ public class CxfBcRMSequenceTest extends
         mf.verifyMessages(3, false);
         expectedActions = new String[] {RM10Constants.INSTANCE.getCreateSequenceResponseAction(),
                                         GREETME_RESPONSE_ACTION,
-                                        null};
+                                        RM10_GENERIC_FAULT_ACTION};
         mf.verifyActions(expectedActions, false);
         mf.verifyMessageNumbers(new String[] {null, "1", null}, false);
         mf.verifyAcknowledgements(new boolean[] {false, true, false} , false);

Modified: servicemix/components/trunk/engines/servicemix-cxf-se/pom.xml
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/engines/servicemix-cxf-se/pom.xml?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/engines/servicemix-cxf-se/pom.xml (original)
+++ servicemix/components/trunk/engines/servicemix-cxf-se/pom.xml Fri Oct 18 13:54:59 2013
@@ -170,6 +170,10 @@
                     <groupId>org.springframework</groupId>
                     <artifactId>spring-jmx</artifactId>
                 </exclusion>
+                <exclusion>
+                    <groupId>woodstox</groupId>
+                    <artifactId>wstx-asl</artifactId>
+                </exclusion>
             </exclusions>
         </dependency>
 

Modified: servicemix/components/trunk/pom.xml
URL: http://svn.apache.org/viewvc/servicemix/components/trunk/pom.xml?rev=1533454&r1=1533453&r2=1533454&view=diff
==============================================================================
--- servicemix/components/trunk/pom.xml (original)
+++ servicemix/components/trunk/pom.xml Fri Oct 18 13:54:59 2013
@@ -89,7 +89,7 @@
         <camel.version>2.12.1</camel.version>
 
         <!-- CXF -->
-        <cxf.version>2.6.4</cxf.version>
+        <cxf.version>2.7.6</cxf.version>
 
         <!-- Geronimo Specs and Modules -->
         <geronimo-activation.version>1.0.2</geronimo-activation.version>
@@ -146,9 +146,9 @@
         <spring.osgi.version>1.2.0</spring.osgi.version>
         <stax-api.version>1.0-2</stax-api.version>
         <woden.version>1.0.0M6</woden.version>
-        <woodstox.version>4.0.8</woodstox.version>
+        <woodstox.version>4.2.0</woodstox.version>
         <wsdl4j.version>1.6.2</wsdl4j.version>
-        <wss4j.version>1.6.8</wss4j.version>
+        <wss4j.version>1.6.10</wss4j.version>
         <xalan.version>2.7.1</xalan.version>
         <xbean.version>3.11.1</xbean.version>
         <xercesImpl.version>2.9.1</xercesImpl.version>