You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ly...@apache.org on 2024/05/16 04:20:04 UTC
(incubator-devlake) branch dev-multi-env updated: feat(webhook): update deployment'display_title field
This is an automated email from the ASF dual-hosted git repository.
lynwee pushed a commit to branch dev-multi-env
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/dev-multi-env by this push:
new 4ebd10971 feat(webhook): update deployment'display_title field
4ebd10971 is described below
commit 4ebd10971e7e5948f8ffb3e805aebe8d2f6e5e92
Author: d4x1 <15...@qq.com>
AuthorDate: Thu May 16 12:19:52 2024 +0800
feat(webhook): update deployment'display_title field
\
---
backend/core/models/domainlayer/devops/cicd_deployment_commit.go | 6 +++++-
backend/plugins/webhook/api/deployments.go | 4 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/backend/core/models/domainlayer/devops/cicd_deployment_commit.go b/backend/core/models/domainlayer/devops/cicd_deployment_commit.go
index 7b24cee6b..0dd0e2ee6 100644
--- a/backend/core/models/domainlayer/devops/cicd_deployment_commit.go
+++ b/backend/core/models/domainlayer/devops/cicd_deployment_commit.go
@@ -51,6 +51,10 @@ func (cicdDeploymentCommit CicdDeploymentCommit) TableName() string {
}
func (cicdDeploymentCommit CicdDeploymentCommit) ToDeployment() *CICDDeployment {
+ return cicdDeploymentCommit.ToDeploymentWithCustomDisplayTitle(cicdDeploymentCommit.DisplayTitle)
+}
+
+func (cicdDeploymentCommit CicdDeploymentCommit) ToDeploymentWithCustomDisplayTitle(displayTitle string) *CICDDeployment {
return &CICDDeployment{
DomainEntity: domainlayer.DomainEntity{
Id: cicdDeploymentCommit.CicdDeploymentId,
@@ -72,7 +76,7 @@ func (cicdDeploymentCommit CicdDeploymentCommit) ToDeployment() *CICDDeployment
},
QueuedDurationSec: cicdDeploymentCommit.QueuedDurationSec,
DurationSec: cicdDeploymentCommit.DurationSec,
- DisplayTitle: cicdDeploymentCommit.DisplayTitle,
+ DisplayTitle: displayTitle,
Url: cicdDeploymentCommit.Url,
}
}
diff --git a/backend/plugins/webhook/api/deployments.go b/backend/plugins/webhook/api/deployments.go
index b1c8b2d28..47ff8e9b9 100644
--- a/backend/plugins/webhook/api/deployments.go
+++ b/backend/plugins/webhook/api/deployments.go
@@ -148,7 +148,7 @@ func CreateDeploymentAndDeploymentCommits(connection *models.WebhookConnection,
return err
}
// create a deployment record
- if err := tx.CreateOrUpdate(deploymentCommit.ToDeployment()); err != nil {
+ if err := tx.CreateOrUpdate(deploymentCommit.ToDeploymentWithCustomDisplayTitle(request.DisplayTitle)); err != nil {
logger.Error(err, "create deployment")
return err
}
@@ -186,7 +186,7 @@ func CreateDeploymentAndDeploymentCommits(connection *models.WebhookConnection,
// create a deployment record
deploymentCommit.Name = name
- if err := tx.CreateOrUpdate(deploymentCommit.ToDeployment()); err != nil {
+ if err := tx.CreateOrUpdate(deploymentCommit.ToDeploymentWithCustomDisplayTitle(request.DisplayTitle)); err != nil {
logger.Error(err, "create deployment")
return err
}