You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/05 06:50:14 UTC

[GitHub] [flink] PatrickRen commented on pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode

PatrickRen commented on pull request #14531:
URL: https://github.com/apache/flink/pull/14531#issuecomment-754439352


   @xiaoHoly Thanks for the pull request~ 
   
   I took more investigation on the logic here. Actually the partition discovery should be enabled by default when: 
   1. Source is unbounded 
   2. **Stopping offset** is not specified. 
   
   The scenario is when user invokes `setUnbounded`  method of the builder to specify stopping offset for partitions. If the partition discovery is also enabled under this scenario, the source will never switch to finished status even if all splits have reached the stopping offsets, because SplitEnumerator won't signal NoMoreSplitsEvent if partition discovery is enabled. 
   
   @xiaoHoly Can you update the code accordingly? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org