You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/09 05:20:50 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

xushiyan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1044099173


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -67,7 +67,7 @@ public enum State {
     // Committed instant
     COMPLETED,
     // Invalid instant
-    INVALID
+    NIL

Review Comment:
   just to confirm no such state can be persisted in any way for actual usage, and it is only meant for testing. By this logic, we should avoid putting this as part of production code, esp. as public API. Can we take this chance to move it to test code? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org