[jira] [Commented] (SANDBOX-348) Implement the Boruvka's algorithm

["Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SANDBOX-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200949#comment-13200949 ] 

Simone Tripodi commented on SANDBOX-348:
----------------------------------------

Hi Thomas!

simply brilliant, thanks for your effort! There's no need to provide a patch, since you are already a commons committer feel free to commit the modifications and don't forget to add yourself in the developers list in the pom ;)

I have just 2 minor observations:

 * There is no reason to keep 2 Boruvka implementations, so let's keep just the fastest

 * I just suggest to move the {{SuperVertex}} in its proper classfile, to simplify the algorithms class.

Very well done, thanks!
                
> Implement the Boruvka's algorithm
> ---------------------------------
>
>                 Key: SANDBOX-348
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-348
>             Project: Commons Sandbox
>          Issue Type: Sub-task
>          Components: Graph
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>         Attachments: BoruvkaTestCase2.java, DefaultSpanningTreeAlgorithmSelector.java, SANDBOX-348-ConnectivityAlgo.patch, SANDBOX-348_Boruvka_algorithm_implementation.patch
>
>
> The class {{org.apache.commons.graph.spanning.Boruvka}} contains an empty implementation of [Boruvka|http://en.wikipedia.org/wiki/Bor%C5%AFvka's_algorithm]'s algorithm, that needs to be filled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira