You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/22 03:38:12 UTC
[GitHub] [apisix] jwrookie opened a new pull request #6682: feat: add optional request method for forward-auth plugin
jwrookie opened a new pull request #6682:
URL: https://github.com/apache/apisix/pull/6682
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Add optional request method for forward-auth plugin, when it is `POST`, the request body will be send to the `authorization` service.
Fixes #6344
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jwrookie commented on a change in pull request #6682: feat: add optional request method for forward-auth plugin
Posted by GitBox <gi...@apache.org>.
jwrookie commented on a change in pull request #6682:
URL: https://github.com/apache/apisix/pull/6682#discussion_r831748621
##########
File path: apisix/plugins/forward-auth.lua
##########
@@ -27,6 +27,12 @@ local schema = {
type = "boolean",
default = true,
},
+ request_method = {
+ type = "string",
+ default = "GET",
+ enum = {"GET", "POST"},
Review comment:
I don't think we need it. it maybe a burden for the user. `GET & POST` is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #6682: feat: add optional request method for forward-auth plugin
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #6682:
URL: https://github.com/apache/apisix/pull/6682#discussion_r831742555
##########
File path: apisix/plugins/forward-auth.lua
##########
@@ -27,6 +27,12 @@ local schema = {
type = "boolean",
default = true,
},
+ request_method = {
+ type = "string",
+ default = "GET",
+ enum = {"GET", "POST"},
Review comment:
How about the `PUT` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6682: feat: add optional request method for forward-auth plugin
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6682:
URL: https://github.com/apache/apisix/pull/6682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org