You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/11 07:12:57 UTC
[GitHub] [maven-parent] slawekjaranowski opened a new pull request, #65: [MPOM-322] Add ASF Data Privacy
slawekjaranowski opened a new pull request, #65:
URL: https://github.com/apache/maven-parent/pull/65
- add link to Data Privacy
- add / copy ASF section to documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] michael-o commented on a diff in pull request #65: [MPOM-322] Add ASF Data Privacy
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #65:
URL: https://github.com/apache/maven-parent/pull/65#discussion_r894991995
##########
doxia-tools/src/site-docs/site.xml:
##########
@@ -37,6 +37,15 @@ under the License.
<item name="Doxia Tools" href="../doxia-tools/index.html"/>
</menu>
- <menu ref="parent" />
Review Comment:
Can you explain why this is not necessary anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] michael-o commented on a diff in pull request #65: [MPOM-322] Add ASF Data Privacy
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #65:
URL: https://github.com/apache/maven-parent/pull/65#discussion_r894995562
##########
doxia-tools/src/site-docs/site.xml:
##########
@@ -37,6 +37,15 @@ under the License.
<item name="Doxia Tools" href="../doxia-tools/index.html"/>
</menu>
- <menu ref="parent" />
Review Comment:
Alright, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski merged pull request #65: [MPOM-322] Add ASF Data Privacy
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #65:
URL: https://github.com/apache/maven-parent/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #65: [MPOM-322] Add ASF Data Privacy
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #65:
URL: https://github.com/apache/maven-parent/pull/65#discussion_r894995210
##########
doxia-tools/src/site-docs/site.xml:
##########
@@ -37,6 +37,15 @@ under the License.
<item name="Doxia Tools" href="../doxia-tools/index.html"/>
</menu>
- <menu ref="parent" />
Review Comment:
few lines above we have list of all modules, so link to parent in this case is duplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org