[PR] Improved: MacroTreeRenderer passes the macro parameters as data and writes to the given writer (OFBIZ-13678) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #2323:
URL: https://github.com/apache/ofbiz-framework/pull/2323

   MacroTreeRenderer built the text of every macro call by hand and compiled it in one environment bound to the writer of its constructor, so it ignored the writer it was given. It now passes the parameters to FtlWriter as data and renders into the writer of each call, which also puts the image of a link inside the link instead of before it, and the replacement of the pipe for OFBIZ-9191 is applied to the link url only instead of to the whole macro text. The macro signatures and the output are unchanged, except that values containing a quote, a backslash or an interpolation, which used to fail to render or to be evaluated, are now rendered as they are, and a missing value is rendered as an empty string instead of the text "null".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: MacroTreeRenderer passes the macro parameters as data and writes to the given writer (OFBIZ-13678) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #2323:
URL: https://github.com/apache/ofbiz-framework/pull/2323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org