You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Michael Clarke <mi...@gmail.com> on 2013/03/30 22:02:40 UTC
Re: JUnit4 requirement
https://github.com/mc1arke/ant/commit/63251494ed70b7694305e43c9cc37879ca3bd5adfixes
this, providing CustomJUnit4AdapterCache is moved into the ant-junit4
JAR. I can make a further commit to reverse the removal of the JUnit4 JAR
and add the CustomJUnit4AdapterCache to the JAR then bundle it up into a
patch if wanted?
Thanks,
Michael
On 30 March 2013 18:44, Stefan Bodewig <bo...@apache.org> wrote:
> On 2013-03-28, Stefan Bodewig wrote:
>
> > On 2013-03-27, Michael Clarke wrote:
>
> >>>> * the optional ant-junit4.jar has been merged into ant-junit.jar
> >>>> as Ant now requires JUnit4.
>
> >> Is it really the case that Ant requires JUnit4? The changes I
> >> introduced for @Ignore annotations in Ant 1.9.0 shouldn't impact
> >> backwards compatibility with JUnit3 and I don't believe any other
> >> changes in the 1.9.0 release force users to need the JUnit4 jar whilst
> >> running tests.
>
> > Some classes in the junit package didn't seem to compile in Gump, I
> > think BriefJUnitFormatter was one of them.
>
> The formatter all now import org.junit.Ignore so require JUnit 4 at
> compile time. It may stil be possible to use JUnit 3 at runtime.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
Re: JUnit4 requirement
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-04-03, Jesse Glick wrote:
> On 04/03/2013 12:14 AM, Stefan Bodewig wrote:
>> I don't really have an opinion myself whether we still want to
>> support JUnit 3.x or not.
> To be clear, we absolutely need to support 3.x *tests*.
In that case I'd be in favor of reverting my commit and making sure
Ant's ant-junit.jar is buildable without JUnit 4.x.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: JUnit4 requirement
Posted by Jesse Glick <jg...@cloudbees.com>.
On 04/03/2013 12:14 AM, Stefan Bodewig wrote:
> I don't really have an opinion myself whether we still want to support JUnit 3.x or not.
To be clear, we absolutely need to support 3.x *tests*. The question is whether we want to mandate that junit-4.*.jar be in the test classpath even for projects using
only JUnit 3.x features. I do not think this is an unreasonable concession to progress, but it will break some builds.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: JUnit4 requirement
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-03-30, Michael Clarke wrote:
> https://github.com/mc1arke/ant/commit/63251494ed70b7694305e43c9cc37879ca3bd5adfixes
> this, providing CustomJUnit4AdapterCache is moved into the ant-junit4
> JAR. I can make a further commit to reverse the removal of the JUnit4 JAR
> and add the CustomJUnit4AdapterCache to the JAR then bundle it up into a
> patch if wanted?
I don't really have an opinion myself whether we still want to support
JUnit 3.x or not. Nobody else either?
We could poll the users list but would likely get the usual mixed bag of
"go ahead, JUnit 4 has been available for X years" and "we cannot
upgrade for political reasons, JUnit 3 support is essential for us".
Given Ant 1.9.0 likely doesn't work with JUnit 3 we may wait a bit and
consider the lack of bug reports a sign that JUnit 3 compatibility isn't
needed anymore.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org