You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jason Brown (JIRA)" <ji...@apache.org> on 2013/01/18 20:48:13 UTC

[jira] [Updated] (CASSANDRA-4464) expose 2I CFs to the rest of nodetool

     [ https://issues.apache.org/jira/browse/CASSANDRA-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Brown updated CASSANDRA-4464:
-----------------------------------

    Attachment: 4464-v1.patch

After talking offline with @driftx, we've decided to wait until 2.0 to incorporate nodetool scrub for 2Is. I will open up a separate ticket for that work. The attached patch addresses the other nodetool commands Jonathan listed.

* upgradesstables - removed assert in CompactionManager.performSSTableRewrite() that checks if CF is index. Can now upgrade 2Is independently, or will automatically upgrade 2Is when doign the owning CF
* invalidate[key|row]cache - ks/cf args were removed in 1.1, thus, no change
* cfstats - now prints out 2I info, ordered below owning CF
* flush - can now flush 2Is independently.
* getsstables - I changed NodeProbe.getCfsProxy() so if cf name has dot (meaning it's a 2I), looks up mbean in IndexColumnFamiles
* rangekeysample - command doesn't take ks/cf as args, and only looks at regular CFs for output; thus, no change
* snapshot - now throws an exception when attempting to snapshot a 2I

                
> expose 2I CFs to the rest of nodetool
> -------------------------------------
>
>                 Key: CASSANDRA-4464
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4464
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jason Brown
>            Priority: Minor
>             Fix For: 1.2.2
>
>         Attachments: 4464.txt, 4464-v1.patch
>
>
> This was begun in CASSANDRA-4063.  We should extend it to scrub as well, and probably compact since any sane way to do it for scrub should give the other for free.
> Not sure how easy these will be since they go through CompactionManager via StorageProxy.  I think getValidColumnFamilies could be updated to check for index CFs with "dot notation."
> (Other operations like flush or snapshot don't make sense for 2I CFs in isolation of their parent.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira