You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ao...@apache.org on 2020/10/05 18:46:44 UTC
[iceberg] branch master updated: Build: Ignore
OverloadMethodsDeclarationOrder rule (#1550)
This is an automated email from the ASF dual-hosted git repository.
aokolnychyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new 89bfab5 Build: Ignore OverloadMethodsDeclarationOrder rule (#1550)
89bfab5 is described below
commit 89bfab5ffcccf26be09e95d6e311c58acf123aae
Author: Anton Okolnychyi <ao...@apple.com>
AuthorDate: Mon Oct 5 11:46:36 2020 -0700
Build: Ignore OverloadMethodsDeclarationOrder rule (#1550)
---
.baseline/checkstyle/checkstyle.xml | 1 -
core/src/main/java/org/apache/iceberg/BaseTableScan.java | 1 -
core/src/main/java/org/apache/iceberg/deletes/PositionDelete.java | 1 -
data/src/main/java/org/apache/iceberg/data/InternalRecordWrapper.java | 1 -
spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java | 1 -
5 files changed, 5 deletions(-)
diff --git a/.baseline/checkstyle/checkstyle.xml b/.baseline/checkstyle/checkstyle.xml
index f6ce651..fe0be1b 100644
--- a/.baseline/checkstyle/checkstyle.xml
+++ b/.baseline/checkstyle/checkstyle.xml
@@ -250,7 +250,6 @@
<property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
</module>
<module name="OuterTypeFilename"/> <!-- Java Style Guide: File name -->
- <module name="OverloadMethodsDeclarationOrder"/> <!-- Java Style Guide: Overloads: never split -->
<module name="PackageAnnotation"/> <!-- Java Style Guide: Package statement -->
<module name="PackageDeclaration"/> <!-- Java Style Guide: Package statement -->
<module name="PackageName"> <!-- Java Style Guide: Package names -->
diff --git a/core/src/main/java/org/apache/iceberg/BaseTableScan.java b/core/src/main/java/org/apache/iceberg/BaseTableScan.java
index 5b2f959..51f8a2e 100644
--- a/core/src/main/java/org/apache/iceberg/BaseTableScan.java
+++ b/core/src/main/java/org/apache/iceberg/BaseTableScan.java
@@ -44,7 +44,6 @@ import org.slf4j.LoggerFactory;
/**
* Base class for {@link TableScan} implementations.
*/
-@SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
abstract class BaseTableScan implements TableScan {
private static final Logger LOG = LoggerFactory.getLogger(TableScan.class);
diff --git a/core/src/main/java/org/apache/iceberg/deletes/PositionDelete.java b/core/src/main/java/org/apache/iceberg/deletes/PositionDelete.java
index 1a2e849..4cd2d31 100644
--- a/core/src/main/java/org/apache/iceberg/deletes/PositionDelete.java
+++ b/core/src/main/java/org/apache/iceberg/deletes/PositionDelete.java
@@ -21,7 +21,6 @@ package org.apache.iceberg.deletes;
import org.apache.iceberg.StructLike;
-@SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
public class PositionDelete<R> implements StructLike {
static <T> PositionDelete<T> create() {
return new PositionDelete<>();
diff --git a/data/src/main/java/org/apache/iceberg/data/InternalRecordWrapper.java b/data/src/main/java/org/apache/iceberg/data/InternalRecordWrapper.java
index 81762aa..a2d0624 100644
--- a/data/src/main/java/org/apache/iceberg/data/InternalRecordWrapper.java
+++ b/data/src/main/java/org/apache/iceberg/data/InternalRecordWrapper.java
@@ -31,7 +31,6 @@ import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
import org.apache.iceberg.util.DateTimeUtil;
-@SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
public class InternalRecordWrapper implements StructLike {
private final Function<Object, Object>[] transforms;
private StructLike wrapped = null;
diff --git a/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java b/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java
index f7f701c..c4d4bb4 100644
--- a/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java
+++ b/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java
@@ -66,7 +66,6 @@ import static org.apache.iceberg.spark.SparkSchemaUtil.convert;
import static scala.collection.JavaConverters.mapAsJavaMapConverter;
import static scala.collection.JavaConverters.seqAsJavaListConverter;
-@SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
public class TestHelpers {
private TestHelpers() {