[superset] branch master updated: test: Fix act errors in PopoverDropdown test (#21361)

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 994a005444 test: Fix act errors in PopoverDropdown test (#21361)
994a005444 is described below

commit 994a0054443c098b99099fcd30e37675f12ff59e
Author: Lyndsi Kay Williams <55...@users.noreply.github.com>
AuthorDate: Thu Sep 8 05:48:18 2022 -0500

    test: Fix act errors in PopoverDropdown test (#21361)
---
 .../PopoverDropdown/PopoverDropdown.test.tsx         | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/superset-frontend/src/components/PopoverDropdown/PopoverDropdown.test.tsx b/superset-frontend/src/components/PopoverDropdown/PopoverDropdown.test.tsx
index 2704e11e0c..2c02eec91a 100644
--- a/superset-frontend/src/components/PopoverDropdown/PopoverDropdown.test.tsx
+++ b/superset-frontend/src/components/PopoverDropdown/PopoverDropdown.test.tsx
@@ -36,19 +36,19 @@ const defaultProps: PopoverDropdownProps = {
   onChange: jest.fn(),
 };
 
-test('renders with default props', () => {
+test('renders with default props', async () => {
   render(<PopoverDropdown {...defaultProps} />);
-  expect(screen.getByRole('button')).toBeInTheDocument();
+  expect(await screen.findByRole('button')).toBeInTheDocument();
   expect(screen.getByRole('button')).toHaveTextContent('Option 1');
 });
 
-test('renders the menu on click', () => {
+test('renders the menu on click', async () => {
   render(<PopoverDropdown {...defaultProps} />);
   userEvent.click(screen.getByRole('button'));
-  expect(screen.getByRole('menu')).toBeInTheDocument();
+  expect(await screen.findByRole('menu')).toBeInTheDocument();
 });
 
-test('renders with custom button', () => {
+test('renders with custom button', async () => {
   render(
     <PopoverDropdown
       {...defaultProps}
@@ -59,10 +59,10 @@ test('renders with custom button', () => {
       )}
     />,
   );
-  expect(screen.getByText('Custom Option 1')).toBeInTheDocument();
+  expect(await screen.findByText('Custom Option 1')).toBeInTheDocument();
 });
 
-test('renders with custom option', () => {
+test('renders with custom option', async () => {
   render(
     <PopoverDropdown
       {...defaultProps}
@@ -74,13 +74,13 @@ test('renders with custom option', () => {
     />,
   );
   userEvent.click(screen.getByRole('button'));
-  expect(screen.getByText('Custom Option 1')).toBeInTheDocument();
+  expect(await screen.findByText('Custom Option 1')).toBeInTheDocument();
 });
 
-test('triggers onChange', () => {
+test('triggers onChange', async () => {
   render(<PopoverDropdown {...defaultProps} />);
   userEvent.click(screen.getByRole('button'));
-  expect(screen.getByText('Option 2')).toBeInTheDocument();
+  expect(await screen.findByText('Option 2')).toBeInTheDocument();
   userEvent.click(screen.getByText('Option 2'));
   expect(defaultProps.onChange).toHaveBeenCalled();
 });