You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/01/12 00:33:00 UTC
[PR] allows compact column in metadata constraint [accumulo]
keith-turner opened a new pull request, #4155:
URL: https://github.com/apache/accumulo/pull/4155
The upgrade code deletes the compact column in the metadata table. The metadata constraint would cause this to fail (confirmed w/ a manual test). This change adds the compact column to the metadata constraint so the upgrade code can delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allows compact column in metadata constraint [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4155:
URL: https://github.com/apache/accumulo/pull/4155#discussion_r1462359385
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java:
##########
@@ -436,6 +436,9 @@ public static class Upgrade12to13 {
public static final String SPLIT_RATIO_QUAL = "splitRatio";
public static final ColumnFQ SPLIT_RATIO_COLUMN =
new ColumnFQ(TabletColumnFamily.NAME, new Text(SPLIT_RATIO_QUAL));
+
Review Comment:
```suggestion
// TODO: Remove this when Upgrader12to13 is removed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allows compact column in metadata constraint [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4155:
URL: https://github.com/apache/accumulo/pull/4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] allows compact column in metadata constraint [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4155:
URL: https://github.com/apache/accumulo/pull/4155#discussion_r1465499474
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java:
##########
@@ -436,6 +436,9 @@ public static class Upgrade12to13 {
public static final String SPLIT_RATIO_QUAL = "splitRatio";
public static final ColumnFQ SPLIT_RATIO_COLUMN =
new ColumnFQ(TabletColumnFamily.NAME, new Text(SPLIT_RATIO_QUAL));
+
Review Comment:
added two TODOs in 68653d6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org