You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/12 01:07:33 UTC

[GitHub] [incubator-tvm] jmorrill commented on a change in pull request #4306: Fix incorrect call to Unicode Win32 InetPton

jmorrill commented on a change in pull request #4306: Fix incorrect call to Unicode Win32 InetPton
URL: https://github.com/apache/incubator-tvm/pull/4306#discussion_r344977112
 
 

 ##########
 File path: src/common/socket.h
 ##########
 @@ -59,7 +59,7 @@ static inline int poll(struct pollfd *pfd, int nfds,
   return WSAPoll(pfd, nfds, timeout);
 }
 static inline int inet_pton(int family, const char* addr_str, void* addr_buf) {
 
 Review comment:
   Good find!  I removed the "static inline int inet_pton" function from socket.h and got a successful build on Windows.
   
   Should I close this PR and resubmit a new PR with it removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services