You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by javierbb31 <gi...@git.apache.org> on 2014/06/23 16:22:35 UTC

[GitHub] cordova-plugin-network-information pull request: Port network test...

GitHub user javierbb31 opened a pull request:

    https://github.com/apache/cordova-plugin-network-information/pull/11

    Port network tests to plugin-test-framework

    Ported test  from mobile-spec (which are written in jasmine 1.3) in
    jasmine 2.0.
    Added:
    New js-module named tests to plugin.xml
    Folder with tests working on jasmine 2.0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/javierbb31/cordova-plugin-network-information CB-6964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-network-information/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 263e3bf21e2f39baa1675e5d1f110de3384db197
Author: javierbb31 <ja...@gmail.com>
Date:   2014-06-20T21:59:32Z

    Port network tests to plugin-test-framework
    
    Ported test  from mobile-spec (which are written in jasmine 1.3) in
    jasmine 2.0.
    Added:
    New js-module named tests to plugin.xml
    Folder with tests working on jasmine 2.0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-network-information pull request: Port network test...

Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-plugin-network-information/pull/11#issuecomment-47387288
  
    Please open a new PR with <js-module> not added to main plugin.xml.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-network-information pull request: Port network test...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-network-information/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---