You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/03 15:32:55 UTC
[GitHub] [pulsar-client-go] wuYin opened a new pull request #460: asynchronized send timeout checking without pending queue lock
wuYin opened a new pull request #460:
URL: https://github.com/apache/pulsar-client-go/pull/460
Fixes #458
### Motivation
For current producer, send timeout checking triggered by interval batch flush
If connection closed, the producer eventloop will blocked to reconnect to broker, lead to batch flush and send timeout checking take no effective, java-client timer did effective in this situation
### Modifications
Asynchronized send timeout by running in independent goroutine until producer closed, and without a pending queue lock
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Others
Without pending queue lock, the send timeout checking gets more complicated, I don't know if it's worth it for performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #460: asynchronized send timeout checking without pending queue lock
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #460:
URL: https://github.com/apache/pulsar-client-go/pull/460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org