You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/04/21 14:38:43 UTC

Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
    https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
-------

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
  ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 8e1671e 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 84bac38 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 


Diff: https://reviews.apache.org/r/58620/diff/1/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/#review173060
-----------------------------------------------------------


Ship it!




Ship It!

- Aravindan Vijayan


On April 26, 2017, 4:57 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58620/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 4:57 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20820
>     https://issues.apache.org/jira/browse/AMBARI-20820
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> To track changes in
> - Stack & AMS Scripts
> - Sinks (Services & Ambari Server)
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
>   ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
>   ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
>   ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 4aadb83 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 7615ee7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 7615ee7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
>   ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py 5a5361c 
>   ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 
> 
> 
> Diff: https://reviews.apache.org/r/58620/diff/5/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/
-----------------------------------------------------------

(Updated \u0410\u043f\u0440\u0435\u043b\u044c 26, 2017, 4:57 \u043f.\u043f.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
    https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
-------

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
  ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py 5a5361c 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 


Diff: https://reviews.apache.org/r/58620/diff/5/

Changes: https://reviews.apache.org/r/58620/diff/4-5/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/#review173058
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
Lines 76 (patched)
<https://reviews.apache.org/r/58620/#comment246132>

    Can we use the cluster name from Ambari? Probably the first cluster name.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
Lines 175 (patched)
<https://reviews.apache.org/r/58620/#comment246133>

    I believe this ams-site config is no longer present. Can we use the external metrics collector config instead?


- Aravindan Vijayan


On April 26, 2017, 10:03 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58620/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 10:03 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-20820
>     https://issues.apache.org/jira/browse/AMBARI-20820
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> To track changes in
> - Stack & AMS Scripts
> - Sinks (Services & Ambari Server)
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
>   ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
>   ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
>   ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 4aadb83 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 7615ee7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 7615ee7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
>   ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py 5a5361c 
>   ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 
> 
> 
> Diff: https://reviews.apache.org/r/58620/diff/4/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/
-----------------------------------------------------------

(Updated \u0410\u043f\u0440\u0435\u043b\u044c 26, 2017, 10:03 \u0434.\u043f.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
    https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
-------

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
  ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py 5a5361c 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 


Diff: https://reviews.apache.org/r/58620/diff/4/

Changes: https://reviews.apache.org/r/58620/diff/3-4/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/
-----------------------------------------------------------

(Updated \u0410\u043f\u0440\u0435\u043b\u044c 25, 2017, 9:16 \u0434.\u043f.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
    https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
-------

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
  ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 8e1671e 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py 5a5361c 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 


Diff: https://reviews.apache.org/r/58620/diff/3/

Changes: https://reviews.apache.org/r/58620/diff/2-3/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/
-----------------------------------------------------------

(Updated \u0410\u043f\u0440\u0435\u043b\u044c 24, 2017, 3:15 \u043f.\u043f.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20820
    https://issues.apache.org/jira/browse/AMBARI-20820


Repository: ambari


Description
-------

To track changes in
- Stack & AMS Scripts
- Sinks (Services & Ambari Server)


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 46f32f9 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 3fdf3f4 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 8e0de03 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 5777639 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/application_metric_map.py 0052808 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py 5686c50 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py ba3f18e 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 9d492cb 
  ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java e1ac48c 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 9a55f10 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 60c1427 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 535fae0 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java f58f549 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java f268149 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 53cf002 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 f7926d0 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 8e1671e 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 919f26d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 8c6f86f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 1505f9b 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py b143941 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 cf2bd6c 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 3177643 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 e808f5d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 7e1abbc 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 7615ee7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 82f71c5 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 f1bfa03 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 d63dfb7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 4c9c981 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml f2b4a76 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 32f18f2 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 44b256e 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 f2a75cf 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 001ff73 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 70ebfeb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py 5a5361c 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2f3aab6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 


Diff: https://reviews.apache.org/r/58620/diff/2/

Changes: https://reviews.apache.org/r/58620/diff/1-2/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen