[jira] [Commented] (LUCENE-5696) Remove Weakhashmap from CachingWrapperFilter

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006253#comment-14006253 ] 

Michael McCandless commented on LUCENE-5696:
--------------------------------------------

+1 to make it explicit.

> Remove Weakhashmap from CachingWrapperFilter
> --------------------------------------------
>
>                 Key: LUCENE-5696
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5696
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> Filters can take up a good amount of space, I think its terrible this thing relies entirely upon weak references.
> Actually I don't think it should use weak references at all, in my opinion, it should instead use a ConcurrentHashmap and coreClosedListeners to purge things.
> We already ensure and test since LUCENE-5553 that these listeners are always fired on close, even under exceptional cases, so I don't understand why we need weak references anywhere.
> So maybe the fix is to just move up coreClosedListener to AtomicReader? And maybe nuke getCoreCacheKey and getCombinedCoreAndDeletesKey.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org