You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2025/02/07 20:40:47 UTC
[PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
hussein-awala opened a new pull request, #46573:
URL: https://github.com/apache/airflow/pull/46573
This PR removes `airflow.operators.email.EmailOperator` operator in favor of `airflow.providers.smtp.operators.smtp.EmailOperator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala merged PR #46573:
URL: https://github.com/apache/airflow/pull/46573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #46573:
URL: https://github.com/apache/airflow/pull/46573#discussion_r1947155739
##########
newsfragments/46572.significant.rst:
##########
@@ -0,0 +1,18 @@
+In Airflow 3.0, ``airflow.operators.email.EmailOperator`` is removed.
+
+Instead, users can install ``smtp`` provider and import ``EmailOperator`` from the the module ``airflow.providers.smtp.operators.smtp``.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+.. * Migration rules needed
+.. TODO: create the migration rule that:
+* Import ``EmailOperator`` from ``airflow.providers.smtp.operators.smtp`` instead of ``airflow.operators.email``
Review Comment:
@Lee-W we need to replace this by the new rule once it is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #46573:
URL: https://github.com/apache/airflow/pull/46573#discussion_r1947993919
##########
airflow/operators/email.py:
##########
@@ -1,91 +0,0 @@
-#
Review Comment:
I remember you said we're going to do that, but I was informed instead of being part of the discussion 🤔
Currently, we still suggest users to use the provider in ruff thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #46573:
URL: https://github.com/apache/airflow/pull/46573#discussion_r1947993965
##########
newsfragments/46572.significant.rst:
##########
@@ -0,0 +1,22 @@
+In Airflow 3.0, ``airflow.operators.email.EmailOperator`` is removed.
+
+Instead, users can install ``smtp`` provider and import ``EmailOperator`` from the the module ``airflow.providers.smtp.operators.smtp``.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+* Migration rules needed
+
+ * ruff
+
+ * <RULE_ID>
Review Comment:
AIR303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #46573:
URL: https://github.com/apache/airflow/pull/46573#discussion_r1947457989
##########
newsfragments/46572.significant.rst:
##########
@@ -0,0 +1,18 @@
+In Airflow 3.0, ``airflow.operators.email.EmailOperator`` is removed.
+
+Instead, users can install ``smtp`` provider and import ``EmailOperator`` from the the module ``airflow.providers.smtp.operators.smtp``.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+.. * Migration rules needed
+.. TODO: create the migration rule that:
+* Import ``EmailOperator`` from ``airflow.providers.smtp.operators.smtp`` instead of ``airflow.operators.email``
Review Comment:
```suggestion
* Migration rules needed
* ruff
* [ ] ``airflow.operators.email`` → ``airflow.providers.smtp.operators.smtp.EmailOperator``
```
##########
newsfragments/46572.significant.rst:
##########
@@ -0,0 +1,18 @@
+In Airflow 3.0, ``airflow.operators.email.EmailOperator`` is removed.
+
+Instead, users can install ``smtp`` provider and import ``EmailOperator`` from the the module ``airflow.providers.smtp.operators.smtp``.
+
+* Types of change
+
+ * [ ] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [x] Code interface changes
+
+.. * Migration rules needed
+.. TODO: create the migration rule that:
+* Import ``EmailOperator`` from ``airflow.providers.smtp.operators.smtp`` instead of ``airflow.operators.email``
Review Comment:
just updated the format so that the script can catch this as a TODO for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BREAKING_CHANGE: remove airflow.operators.email.EmailOperator in favor of SMTP provider operator [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #46573:
URL: https://github.com/apache/airflow/pull/46573#discussion_r1947923324
##########
airflow/operators/email.py:
##########
@@ -1,91 +0,0 @@
-#
Review Comment:
Can't remember now - I think we agreed that we will do "redirection" of all such moved providers - but I totally don't remember what we settled on @Lee-W ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org