You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "alberto-art3ch (via GitHub)" <gi...@apache.org> on 2024/11/04 10:23:28 UTC
[PR] FINERACT-2081: Fix WholeTerm loan frequency saved on account level [fineract]
alberto-art3ch opened a new pull request, #4142:
URL: https://github.com/apache/fineract/pull/4142
## Description
WholeTerm loan frequency saved on account level is displayed as PerYear because It is being inherit from Loan Product.
[FINERACT-2081](https://issues.apache.org/jira/browse/FINERACT-2081)
<img width="953" alt="Screenshot 2024-11-04 at 4 25 35 a m" src="https://github.com/user-attachments/assets/3ba04bd8-7478-4c8a-9f5b-3d87a2575d65">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Fix WholeTerm loan frequency saved on account level [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4142:
URL: https://github.com/apache/fineract/pull/4142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Fix WholeTerm loan frequency saved on account level [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4142:
URL: https://github.com/apache/fineract/pull/4142#discussion_r1827599754
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:
##########
@@ -5473,6 +5475,45 @@ public void uc149() {
});
}
+ // UC150: Validate interestRateFrequencyType to set as Whole Term at the Loan account level
Review Comment:
Would you enhance this test case or create a new one which validate the proper interest rate is set and used? I would say validating whether the proper annual interest rate is on the loan and the calculated interest is matching would be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2081: Fix WholeTerm loan frequency saved on account level [fineract]
Posted by "alberto-art3ch (via GitHub)" <gi...@apache.org>.
alberto-art3ch commented on code in PR #4142:
URL: https://github.com/apache/fineract/pull/4142#discussion_r1829760286
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java:
##########
@@ -5473,6 +5475,45 @@ public void uc149() {
});
}
+ // UC150: Validate interestRateFrequencyType to set as Whole Term at the Loan account level
Review Comment:
Done! Fix to have the right annual interest rate using whole term option applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org