You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/12/08 22:36:52 UTC

[Toolchain-CR] Allow overriding of Kudu github URL 

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5430

Change subject: Allow overriding of Kudu github URL
......................................................................

Allow overriding of Kudu github URL

This is a convenience to allow developers to build a branch of
kudu from a different github account (e.g. their own fork).

Testing:
Tested it locally on the private github enterprise repo. The kudu
build is still in progress but it successfully downloaded the
tarball and started building it.

Also confirmed that it still works if the URL is unspecified

Also confirmed that it still works if the URL is unspecified.

Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
---
M source/kudu/build.sh
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/30/5430/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Toolchain-CR] Allow overriding of Kudu github URL

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5430

to look at the new patch set (#2).

Change subject: Allow overriding of Kudu github URL
......................................................................

Allow overriding of Kudu github URL

This is a convenience to allow developers to build a branch of
kudu from a different github account (e.g. their own fork).

Testing:
Tested it locally on a private github enterprise repo. The kudu
build is still in progress but it successfully downloaded the
tarball and started building it.

Also confirmed that it still works if the URL is unspecified.

Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
---
M source/kudu/build.sh
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/30/5430/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>

[Toolchain-CR] Allow overriding of Kudu github URL

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: Allow overriding of Kudu github URL
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

thanks

http://gerrit.cloudera.org:8080/#/c/5430/1//COMMIT_MSG
Commit Message:

PS1, Line 16: 
            : Also confirmed that it still works if the URL is unspecified
            : 
            : Also confirmed that it still works if the URL is unspecified.
dupe


-- 
To view, visit http://gerrit.cloudera.org:8080/5430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes

[Toolchain-CR] Allow overriding of Kudu github URL

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: Allow overriding of Kudu github URL
......................................................................


Patch Set 2: Verified+1

Tested manually - this should not affect the output of buildall.sh so I didn't do a full rebuild.

-- 
To view, visit http://gerrit.cloudera.org:8080/5430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Toolchain-CR] Allow overriding of Kudu github URL

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.

Change subject: Allow overriding of Kudu github URL
......................................................................


Allow overriding of Kudu github URL

This is a convenience to allow developers to build a branch of
kudu from a different github account (e.g. their own fork).

Testing:
Tested it locally on a private github enterprise repo. The kudu
build is still in progress but it successfully downloaded the
tarball and started building it.

Also confirmed that it still works if the URL is unspecified.

Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
---
M source/kudu/build.sh
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Tim Armstrong: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Toolchain-CR] Allow overriding of Kudu github URL

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: Allow overriding of Kudu github URL
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5430/1//COMMIT_MSG
Commit Message:

PS1, Line 16: 
            : Also confirmed that it still works if the URL is unspecified
            : 
            : Also confirmed that it still works if the URL is unspecified.
> dupe
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I181c599816435ca4997d84a6cd90386c3841ce42
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes